util: do not mark experimental feature as deprecated

PR-URL: #55740 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
nodejs · Nov 16, 2024 · 3a9733c · 3a9733c
1 parent db0d648
commit 3a9733c
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 18 deletions.
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -3754,18 +3754,7 @@ Instantiating classes without the `new` qualifier exported by the `node:repl` mo
 It is recommended to use the `new` qualifier instead. This applies to all REPL classes, including
 `REPLServer` and `Recoverable`.
 
-### DEP0186: `util.getCallSite`
-
-<!-- YAML
-changes:
-  - version: REPLACEME
-    pr-url: https://github.com/nodejs/node/pull/55626
-    description: Runtime deprecation.
--->
-
-Type: Runtime
-
-The `util.getCallSite` API has been removed. Please use [`util.getCallSites()`][] instead.
+<!-- md-lint skip-deprecation DEP0186 -->
 
 [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
 [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
@@ -3892,7 +3881,6 @@ The `util.getCallSite` API has been removed. Please use [`util.getCallSites()`][
 [`url.parse()`]: url.md#urlparseurlstring-parsequerystring-slashesdenotehost
 [`url.resolve()`]: url.md#urlresolvefrom-to
 [`util._extend()`]: util.md#util_extendtarget-source
-[`util.getCallSites()`]: util.md#utilgetcallsitesframecountoroptions-options
 [`util.getSystemErrorName()`]: util.md#utilgetsystemerrornameerr
 [`util.inspect()`]: util.md#utilinspectobject-options
 [`util.inspect.custom`]: util.md#utilinspectcustom

diff --git a/doc/api/util.md b/doc/api/util.md
@@ -370,6 +370,10 @@ util.formatWithOptions({ colors: true }, 'See object %O', { foo: 42 });
 
 <!-- YAML
 added: v22.9.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/55626
+    description: The API is renamed from `util.getCallSite` to `util.getCallSites()`.
 -->
 
 * `frameCount` {number} Optional number of frames to capture as call site objects.

diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -107,7 +107,9 @@ function getDeprecationWarningEmitter(
   return function() {
     if (!warned && shouldEmitWarning()) {
       warned = true;
-      if (code !== undefined) {
+      if (code === 'ExperimentalWarning') {
+        process.emitWarning(msg, code, deprecated);
+      } else if (code !== undefined) {
         if (!codesWarned.has(code)) {
           const emitWarning = useEmitSync ?
             require('internal/process/warning').emitWarningSync :

diff --git a/lib/util.js b/lib/util.js
@@ -436,8 +436,8 @@ module.exports = {
   // Deprecated getCallSite.
   // This API can be removed in next semver-minor release.
   getCallSite: deprecate(getCallSites,
-                         'The `util.getCallSite` API is deprecated. Please use `util.getCallSites()` instead.',
-                         'DEP0186'),
+                         'The `util.getCallSite` API has been renamed to `util.getCallSites()`.',
+                         'ExperimentalWarning'),
   getCallSites,
   getSystemErrorMap,
   getSystemErrorName,

diff --git a/test/parallel/test-util-getcallsite.js b/test/parallel/test-util-getcallsite.js
@@ -4,6 +4,6 @@ require('../common');
 const { getCallSite } = require('node:util');
 const { expectWarning } = require('../common');
 
-const warning = 'The `util.getCallSite` API is deprecated. Please use `util.getCallSites()` instead.';
-expectWarning('DeprecationWarning', warning, 'DEP0186');
+const warning = 'The `util.getCallSite` API has been renamed to `util.getCallSites()`.';
+expectWarning('ExperimentalWarning', warning);
 getCallSite();