v21.7.1 release proposal #52002

targos · 2024-03-07T10:52:07Z

2024-03-08, Version 21.7.1 (Current), @targos

Notable Changes

This release reverts #51389, which
landed in Node.js 21.7.0. It is a documented feature that t.after() hooks are
run even if a test has no subtests. The hook can be used to clean up the test
itself.

Commits

[0dfe810ac7] - benchmark: update iterations of benchmark/async_hooks/async-local- (Lei Shi) #51420
[625c9e0ac9] - benchmark: update iterations of benchmark/domain/domain-fn-args.js (Lei Shi) #51408
[7ff3551bad] - build: fix arm64 host cross-compilation in GN (Cheng Zhao) #51903
[fd86ea8b71] - Revert "build: workaround for node-core-utils" (Richard Lau) #51975
[23c32ab3a7] - build: respect the NODE env variable in Makefile (Antoine du Hamel) #51743
[9617adc064] - Revert "build: fix warning in cares under GN build" (Luigi Pinca) #51865
[5864534095] - deps: update nghttp2 to 1.60.0 (Node.js GitHub Bot) #51948
[fcf235d623] - doc: add policy for distribution (Geoffrey Booth) #51918
[87d2acc8b1] - doc: fix actual result of example is different in events (Deokjin Kim) #51925
[5908c121c6] - doc: clarify Corepack threat model (Antoine du Hamel) #51917
[20e0ba3b94] - doc,module: clarify hook chain execution sequence (Jacob Smith) #51884
[4d997971ac] - lib: make sure close net server (theanarkh) #51929
[fcc6d54aa3] - lib: return directly if udp socket close before lookup (theanarkh) #51914
[10aaabd158] - meta: bump github/codeql-action from 3.23.2 to 3.24.6 (dependabot[bot]) #51942
[78f38a0143] - meta: bump actions/upload-artifact from 4.3.0 to 4.3.1 (dependabot[bot]) #51941
[42ca5452c4] - meta: bump codecov/codecov-action from 4.0.1 to 4.1.0 (dependabot[bot]) #51940
[015a157375] - meta: bump actions/cache from 4.0.0 to 4.0.1 (dependabot[bot]) #51939
[e476cb4a32] - meta: bump actions/download-artifact from 4.1.1 to 4.1.3 (dependabot[bot]) #51938
[67e8001790] - meta: bump actions/setup-node from 4.0.1 to 4.0.2 (dependabot[bot]) #51937
[50343636e8] - src: fix --disable-single-executable-application (Joyee Cheung) #51808
[a48c9ca0db] - stream: do not defer construction by one microtick (Matteo Collina) #52005
[bee3b364f9] - test: add regression test for test_runner after hook (Colin Ihrig) #51998
[fff7f48f50] - test: reduce flakiness of test-runner-output (Antoine du Hamel) #51952
[57ba8f5acb] - test: fix flaky http-chunk-extensions-limit test (Ethan Arrowood) #51943
[9d2c03990a] - test: remove flaky designation (Luigi Pinca) #51736
[e992af81d3] - test: skip SEA tests when SEA generation fails (Joyee Cheung) #51887
[85aa6ca850] - Revert "test_runner: do not invoke after hook when test is empty" (Colin Ihrig) #51998

PR-URL: #51914 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Previously it would not compile if the build is configured with --disable-single-executable-application because we use directives to exclude the definition of SEA-related code completely. This patch changes them so that the SEA code are still compiled and internals can still check whether the executable is an SEA. The executable would not try to load the SEA blob at all if SEA is disabled. If future modifications to the C++ code attempt to load the SEA blob when SEA is disabled, UNREACHABLE() would be raised. If user attempt to generate the SEA blob with --experimental-sea-config with an executable that disables SEA, they would get an error. PR-URL: #51808 Fixes: #51730 Reviewed-By: Tobias Nießen <[email protected]>

In the SEA tests, if any of these steps fail: 1. Copy the executable 2. Inject the SEA blob 3. Signing the SEA We skip the test because the error likely comes from the system or postject and is not something the Node.js core can fix. We only leave an exception for a basic test that test injecting empty files as SEA to ensure the workflow is working (but we still skip if copying fails or signing fails on Windows). PR-URL: #51887 Refs: #49630 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: #51917 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Searching the automatically-generated test failure reports in the issues at https://github.com/nodejs/reliability/issues, I don't see `test-worker-message-port-message-before-close` failing any time recently. PR-URL: #51736 Reviewed-By: Joyee Cheung <[email protected]>

PR-URL: #51884 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

Refs: #50428 PR-URL: #51925 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

PR-URL: #51918 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

This reverts commit f22802c. PR-URL: #51865 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

PR-URL: #51929 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@b39b52d...60edb5d) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #51937 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.1 to 4.1.3. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@6b208ae...87c5514) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #51938 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Bumps [actions/cache](https://github.com/actions/cache) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@13aacd8...ab5e6d0) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #51939 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@e0b68c6...54bcd87) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #51940 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@26f96df...5d5d22a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #51941 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.23.2 to 3.24.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b7bf0a3...8a470fd) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #51942 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Replace the setInterval with a queueMicrotask to make test less flaky. Fixes: #51883 PR-URL: #51943 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>

PR-URL: #51743 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

Fixes: #50571 PR-URL: #51408 Reviewed-By: Chengzhong Wu <[email protected]>

storage-getstore-nested-resources.js Fixes: #50571 PR-URL: #51420 Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #51948 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

This reverts commit b2a6083. PR-URL: #51975 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

PR-URL: #51952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>

Should use `current_cpu` instead of `target_cpu` in GN build files, otherwise the host build may use wrong configs when doing cross compilation. PR-URL: #51903 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

This reverts commit a53fd95. This caused a regression because the original issue this commit was attempting to fix is not a bug. The after() hook should always run. Fixes: #51997 PR-URL: #51998 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Refs: #51997 PR-URL: #51998 Fixes: #51997 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

nodejs-github-bot · 2024-03-07T10:52:12Z

nodejs-github-bot · 2024-03-07T15:29:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57616/

UlisesGascon

LGTM!

Fixes: #51993 PR-URL: #52005 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Notable changes: This release reverts #51389, which landed in Node.js 21.7.0. It is a documented feature that `t.after()` hooks are run even if a test has no subtests. The hook can be used to clean up the test itself. PR-URL: #52002

targos · 2024-03-08T13:40:27Z

Added #52005

Notable changes: This release reverts #51389, which landed in Node.js 21.7.0. It is a documented feature that `t.after()` hooks are run even if a test has no subtests. The hook can be used to clean up the test itself. PR-URL: #52002

nodejs-github-bot · 2024-03-08T13:43:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57632/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3399/

targos · 2024-03-08T13:45:12Z

Optimistic release build: https://ci-release.nodejs.org/job/iojs+release/10022/
Rebuild for arm64 Windows: https://ci-release.nodejs.org/job/iojs+release/10023/

PR-URL: #52002

Notable changes: This release reverts #51389, which landed in Node.js 21.7.0. It is a documented feature that `t.after()` hooks are run even if a test has no subtests. The hook can be used to clean up the test itself. PR-URL: #52002

Refs: nodejs/node#52002

Notable changes: This release reverts nodejs#51389, which landed in Node.js 21.7.0. It is a documented feature that `t.after()` hooks are run even if a test has no subtests. The hook can be used to clean up the test itself. PR-URL: nodejs#52002

theanarkh and others added 26 commits March 7, 2024 10:27

lib: return directly if udp socket close before lookup

fcc6d54

PR-URL: #51914 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

doc,module: clarify hook chain execution sequence

20e0ba3

PR-URL: #51884 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

doc: fix actual result of example is different in events

87d2acc

Refs: #50428 PR-URL: #51925 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

doc: add policy for distribution

fcf235d

PR-URL: #51918 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

Revert "build: fix warning in cares under GN build"

9617adc

This reverts commit f22802c. PR-URL: #51865 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

build: respect the NODE env variable in Makefile

23c32ab

PR-URL: #51743 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

benchmark: update iterations of benchmark/domain/domain-fn-args.js

625c9e0

Fixes: #50571 PR-URL: #51408 Reviewed-By: Chengzhong Wu <[email protected]>

benchmark: update iterations of benchmark/async_hooks/async-local-

0dfe810

storage-getstore-nested-resources.js Fixes: #50571 PR-URL: #51420 Reviewed-By: Chengzhong Wu <[email protected]>

deps: update nghttp2 to 1.60.0

5864534

PR-URL: #51948 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

Revert "build: workaround for node-core-utils"

fd86ea8

This reverts commit b2a6083. PR-URL: #51975 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

test: reduce flakiness of test-runner-output

fff7f48

PR-URL: #51952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>

targos added the release Issues and PRs related to Node.js releases. label Mar 7, 2024

nodejs-github-bot added build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. labels Mar 7, 2024

ronag approved these changes Mar 7, 2024

View reviewed changes

targos mentioned this pull request Mar 7, 2024

Undici failures nodejs/citgm#1051

Closed

RafaelGSS approved these changes Mar 7, 2024

View reviewed changes

marco-ippolito approved these changes Mar 7, 2024

View reviewed changes

anonrig approved these changes Mar 7, 2024

View reviewed changes

richardlau mentioned this pull request Mar 7, 2024

stream: do not defer construction by one microtick #52005

Closed

UlisesGascon approved these changes Mar 7, 2024

View reviewed changes

climba03003 mentioned this pull request Mar 8, 2024

test_runner (after) doesn't work on v21.7.0 #52013

Closed

stream: do not defer construction by one microtick

a48c9ca

Fixes: #51993 PR-URL: #52005 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

targos force-pushed the v21.7.1-proposal branch from 67c970d to 5d3e3ef Compare March 8, 2024 13:40

2024-03-08, Version 21.7.1 (Current)

84c7e6f

Notable changes: This release reverts #51389, which landed in Node.js 21.7.0. It is a documented feature that `t.after()` hooks are run even if a test has no subtests. The hook can be used to clean up the test itself. PR-URL: #52002

targos force-pushed the v21.7.1-proposal branch from 5d3e3ef to 84c7e6f Compare March 8, 2024 13:41

richardlau approved these changes Mar 8, 2024

View reviewed changes

targos merged commit 84c7e6f into v21.x Mar 8, 2024
48 of 51 checks passed

targos added a commit that referenced this pull request Mar 8, 2024

Working on v21.7.2

6209d54

PR-URL: #52002

targos deleted the v21.7.1-proposal branch March 8, 2024 21:47

targos mentioned this pull request Mar 8, 2024

Blog: v21.7.1 release post nodejs/nodejs.org#6468

Merged

5 tasks

targos added a commit to targos/nodejs.org that referenced this pull request Mar 8, 2024

Blog: v21.7.1 release post

24a0a57

Refs: nodejs/node#52002

targos added a commit to targos/nodejs.org that referenced this pull request Mar 8, 2024

Blog: v21.7.1 release post

af3434a

Refs: nodejs/node#52002

targos mentioned this pull request Mar 8, 2024

[legacy] Blog: v21.7.1 release post nodejs/nodejs.org#6469

Merged

5 tasks

github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Mar 8, 2024

Blog: v21.7.1 release post (#6468)

d0e1109

Refs: nodejs/node#52002

richardlau pushed a commit to nodejs/nodejs.org that referenced this pull request Mar 9, 2024

Blog: v21.7.1 release post (#6469)

58fdf75

Refs: nodejs/node#52002

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v21.7.1 release proposal #52002

v21.7.1 release proposal #52002

targos commented Mar 7, 2024 •

edited

Loading

nodejs-github-bot commented Mar 7, 2024

nodejs-github-bot commented Mar 7, 2024

UlisesGascon left a comment

targos commented Mar 8, 2024

nodejs-github-bot commented Mar 8, 2024 •

edited by targos

Loading

targos commented Mar 8, 2024 •

edited

Loading

v21.7.1 release proposal #52002

v21.7.1 release proposal #52002

Conversation

targos commented Mar 7, 2024 • edited Loading

2024-03-08, Version 21.7.1 (Current), @targos

Notable Changes

Commits

nodejs-github-bot commented Mar 7, 2024

nodejs-github-bot commented Mar 7, 2024

UlisesGascon left a comment

Choose a reason for hiding this comment

targos commented Mar 8, 2024

nodejs-github-bot commented Mar 8, 2024 • edited by targos Loading

targos commented Mar 8, 2024 • edited Loading

targos commented Mar 7, 2024 •

edited

Loading

nodejs-github-bot commented Mar 8, 2024 •

edited by targos

Loading

targos commented Mar 8, 2024 •

edited

Loading