stream: do not defer construction by one microtick

Fixes: #51993 PR-URL: #52005 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs · Mar 8, 2024 · a48c9ca · a48c9ca
1 parent bee3b36
commit a48c9ca
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 5 deletions.
diff --git a/lib/internal/streams/destroy.js b/lib/internal/streams/destroy.js
@@ -291,7 +291,7 @@ function constructNT(stream) {
     } else if (err) {
       errorOrDestroy(stream, err, true);
     } else {
-      process.nextTick(emitConstructNT, stream);
+      stream.emit(kConstruct);
     }
   }
 
@@ -304,10 +304,6 @@ function constructNT(stream) {
   }
 }
 
-function emitConstructNT(stream) {
-  stream.emit(kConstruct);
-}
-
 function isRequest(stream) {
   return stream?.setHeader && typeof stream.abort === 'function';
 }

diff --git a/test/parallel/test-fs-writestream-open-write.js b/test/parallel/test-fs-writestream-open-write.js
@@ -0,0 +1,28 @@
+'use strict';
+
+const common = require('../common');
+const tmpdir = require('../common/tmpdir');
+const { strictEqual } = require('assert');
+const fs = require('fs');
+
+// Regression test for https://github.com/nodejs/node/issues/51993
+
+tmpdir.refresh();
+
+const file = tmpdir.resolve('test-fs-writestream-open-write.txt');
+
+const w = fs.createWriteStream(file);
+
+w.on('open', common.mustCall(() => {
+  w.write('hello');
+
+  process.nextTick(() => {
+    w.write('world');
+    w.end();
+  });
+}));
+
+w.on('close', common.mustCall(() => {
+  strictEqual(fs.readFileSync(file, 'utf8'), 'helloworld');
+  fs.unlinkSync(file);
+}));