Revert "test_runner: do not invoke after hook when test is empty"

This reverts commit a53fd95. This caused a regression because the original issue this commit was attempting to fix is not a bug. The after() hook should always run. Fixes: #51997 PR-URL: #51998 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs · Mar 7, 2024 · 85aa6ca · 85aa6ca
1 parent 7ff3551
commit 85aa6ca
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -595,9 +595,7 @@ class Test extends AsyncResource {
 
     const { args, ctx } = this.getRunArgs();
     const after = async () => {
-      // If its a root test then check for global after hook else check for parent after hook
-      const check = this.parent ? this.parent.hooks.after.length > 0 : this.hooks.after.length > 0;
-      if (check) {
+      if (this.hooks.after.length > 0) {
         await this.runHook('after', { __proto__: null, args, ctx });
       }
     };

diff --git a/test/parallel/test-runner-skip-after-hook.js b/test/parallel/test-runner-skip-after-hook.js