v17.2.0 release proposal #40983
Merged
v17.2.0 release proposal #40983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ESLint, Babel, remark, and so on. Run once a week. PR-URL: #40644 Reviewed-By: Antoine du Hamel <[email protected]>
The --production flag has no effect in this situation. Remove it. Add --ignore-scripts as a precaution. PR-URL: #40644 Reviewed-By: Antoine du Hamel <[email protected]>
Add missing semicolons that will be flagged when we update @babel/eslint-parser to 7.16.0. PR-URL: #40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Co-authored-by: Jean Burellier <[email protected]> Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40235 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Voltrex <[email protected]>
PR-URL: #40748 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
- Since we now just reference the nodejs blog post in the post to the nodejs-sec mailing list, change the order so the blog post comes first Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40725 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Refs: #40272 Refs: #20235 PR-URL: #40713 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refs: https://github.com/unicode-org/icu/releases/tag/release-70-1 PR-URL: #40658 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Do not ask to separate the changes in deps/icu-small and in the LICENSE file. Do not ask to remove the whitespace changes. The way commits are landed now doesn't eliminate them anymore. PR-URL: #40658 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #40762 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #40572 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
PR-URL: #40701 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
PR-URL: #39809 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: James M Snell <[email protected]>
The markdown-linter (lint-md) is failing because of a missing newline caused by 79d6815. PR-URL: #40780 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Split the test into seven tests so that it doesn't time out. Fixes: #40694 Fixes: #38088 PR-URL: #40763 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Bradley Farias <[email protected]>
PR-URL: #40726 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
* add missing semicolon to fix:
In file included from ../src/node_crypto.h:47,
from ../src/node.cc:46:
../src/crypto/crypto_scrypt.h:80:2:
error: expected ';' after struct definition
80 | }
| ^
| ;
and fix typo in the comment
Signed-off-by: Martin Jansa <[email protected]>
PR-URL: #40613
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
There was a missing callback in the Transform#flush example implementation. PR-URL: #40777 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Add missing initialization reported by coverity scan. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40555 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
When the file read position is moved passing zero is not respected and `null` is used instead. PR fixes the issues by using nullish coalescing which will return the rhs only when the lhs is `null` or `undefined`; respecting the zero. Fixes: #40715 PR-URL: #40716 Fixes: #40699 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
I noticed that we were taking `TimerCb` as a `const&` and then copying that into the member. This is completely fine when the constructor is called with an lvalue. However, when called with an rvalue, we can allow the `std::function` to be moved into the member instead of falling back to a copy, so I changed the constructors to take in universal references. Also, `std::function` constructors can take in multiple arguments, so I further modified the constructors to use variadic templates. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40665 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
By the design of `GetSSLError()`, the V8 API was unnecessarily being accessed in places where it eventually didn't get used. So this refactor inlines the function appropriately in places where it was being used. Also, this replaces uses of `AllocatedBuffers` with `BackingStore`s. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40675 Reviewed-By: Anna Henningsen <[email protected]>
docs: add asyncWrapProviders api doc tests(async_hooks): use internalBinding for comparisson fix(test-async-wrap): lint error docs: use REPLACEME for asyncWrapProviders update: use freeze and copy for asyncWrapProviders update(async_hooks): use primordials on asyncWrapProviders fix: use common to expect error docs(asyncWrapProviders): rephrase return type fix: lint md fix: lint md docs(async_hooks): typo Co-authored-by: Stephen Belanger <[email protected]> update(asyncWrapProviders): add __proto__ as null Co-authored-by: Simone Busoli <[email protected]> Co-authored-by: Michaël Zasso <[email protected]> test: adjust __proto__ assertion docs: add DEP0111 link PR-URL: #40760 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: #40792 Reviewed-By: Voltrex <[email protected]> Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #40740 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40752 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
PR-URL: #40782 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
PR-URL: #40768 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #39535 PR-URL: #40772 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
Can we get #40941 as well? |
This was referenced Nov 28, 2021
Fixes: #40935 PR-URL: #40947 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Fixes: #40938 PR-URL: #40941 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Notable changes: async_hooks: * (SEMVER-MINOR) expose async_wrap providers (Rafael Gonzaga) #40760 deps: * (SEMVER-MINOR) update V8 to 9.6.180.14 (Michaël Zasso) #40488 lib: * (SEMVER-MINOR) add reason to AbortSignal (James M Snell) #40807 src: * (SEMVER-MINOR) add x509.fingerprint512 to crypto module (3nprob) #39809 stream: * deprecate thenable support (Antoine du Hamel) #40860 * fix finished regression when working with legacy Stream (Matteo Collina) #40858 PR-URL: #40983
targos
force-pushed
the
v17.2.0-proposal
branch
from
bfc56f5
to
1aaa4eb
Compare
BethGriggs
approved these changes
Nov 29, 2021
richardlau
approved these changes
Nov 29, 2021
ronag
approved these changes
Nov 29, 2021
|
@mcollina there are a lot of failures with Fastify. |
v17.0.0 and v17.1.0 did not work with Fastify due to a few regressions on streams. https://github.com/fastify/fastify/pull/3456/files Once this version is released I'll update my PR and hopefully it would work fine. |
targos
added a commit
that referenced
this pull request
Nov 30, 2021
Notable changes: async_hooks: * (SEMVER-MINOR) expose async_wrap providers (Rafael Gonzaga) #40760 deps: * (SEMVER-MINOR) update V8 to 9.6.180.14 (Michaël Zasso) #40488 lib: * (SEMVER-MINOR) add reason to AbortSignal (James M Snell) #40807 src: * (SEMVER-MINOR) add x509.fingerprint512 to crypto module (3nprob) #39809 stream: * deprecate thenable support (Antoine du Hamel) #40860 * fix finished regression when working with legacy Stream (Matteo Collina) #40858 PR-URL: #40983
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
Nov 30, 2021
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 30, 2021
36 tasks
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Notable changes: async_hooks: * (SEMVER-MINOR) expose async_wrap providers (Rafael Gonzaga) nodejs#40760 deps: * (SEMVER-MINOR) update V8 to 9.6.180.14 (Michaël Zasso) nodejs#40488 lib: * (SEMVER-MINOR) add reason to AbortSignal (James M Snell) nodejs#40807 src: * (SEMVER-MINOR) add x509.fingerprint512 to crypto module (3nprob) nodejs#39809 stream: * deprecate thenable support (Antoine du Hamel) nodejs#40860 * fix finished regression when working with legacy Stream (Matteo Collina) nodejs#40858 PR-URL: nodejs#40983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-11-30, Version 17.2.0 (Current), @targos
Notable Changes
06916490af] - (SEMVER-MINOR) async_hooks: expose async_wrap providers (Rafael Gonzaga) #40760371ee64c92] - (SEMVER-MINOR) deps: update V8 to 9.6.180.14 (Michaël Zasso) #40488675c210b04] - (SEMVER-MINOR) lib: add reason to AbortSignal (James M Snell) #408070de2850680] - (SEMVER-MINOR) src: add x509.fingerprint512 to crypto module (3nprob) #39809fa9b5c35d2] - stream: deprecate thenable support (Antoine du Hamel) #40860534409d4e7] - stream: fix finished regression when working with legacy Stream (Matteo Collina) #40858Commits
48157c44c2] - Revert "async_hooks: merge resource_symbol with owner_symbol" (Darshan Sen) #407414a971f67e4] - async_hooks: eliminate require side effects (Stephen Belanger) #4078206916490af] - (SEMVER-MINOR) async_hooks: expose async_wrap providers (Rafael Gonzaga) #4076065b33ba510] - build: remove extraneous quotation marks from commit body (Rich Trott) #4096305d652a555] - build: fix branch name for lint-md-dependencies update (Rich Trott) #409241482c4415f] - build: fixmakeinvocation in tools.yml (Rich Trott) #4089069de8c8143] - build: reset embedder string to "-node.0" (Michaël Zasso) #40488e793331322] - build: fix tools.yml errors (Rich Trott) #4087051ac59b047] - build: add GitHub Action to update tools modules (Rich Trott) #40644a8cc8b6554] - crypto: trim input for NETSCAPE_SPKI_b64_decode (Shelley Vohr) #407572979c58fb0] - crypto: throw errors in SignTraits::DeriveBits (Tobias Nießen) #407967f5931d03f] - crypto: fix build without scrypt (Martin Jansa) #4061390f35fc329] - deps: upgrade npm to 8.1.4 (npm team) #40865d461603d71] - deps: V8: cherry-pick cced52a97ee9 (Ray Wang) #40656d6ae50ff96] - deps: V8: cherry-pick 7ae0b77628f6 (Ray Wang) #40882e60053deee] - deps: V8: cherry-pick 2a0bc36dec12 (Michaël Zasso) #4017894acaae3d4] - deps: V8: patch jinja2 for Python 3.10 compat (Michaël Zasso) #4029637c9828d39] - deps: disable trap handler for Windows cross-compiler (Michaël Zasso) #40488dfb97fb501] - deps: silence irrelevant V8 warning (Michaël Zasso) #389909ecf4be0c2] - deps: silence irrelevant V8 warning (Michaël Zasso) #3758782a8736dec] - deps: fix V8 build issue with inline methods (Jiawen Geng) #38807eab5ef5505] - deps: make v8.h compatible with VS2015 (Joao Reis) #32116d6e5dd56ff] - deps: V8: forward declaration ofRtl*FunctionTable(Refael Ackermann) #3211629a6e15480] - deps: V8: patch register-arm64.h (Refael Ackermann) #321161ff83c4945] - deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #32116371ee64c92] - (SEMVER-MINOR) deps: update V8 to 9.6.180.14 (Michaël Zasso) #404886506a42c16] - deps: V8: cherry-pick cced52a97ee9 (Ray Wang) #40656a612ecb42f] - deps: V8: cherry-pick 7ae0b77628f6 (Ray Wang) #40882b46184df5e] - deps: update to uvwasi 0.0.12 (Colin Ihrig) #40847fa37428472] - deps: add -fno-strict-aliasing flag to libuv (Daniel Bevenius) #406319711ccfe08] - deps: upgrade npm to 8.1.3 (npm team) #407268e525634c6] - deps: update ICU to 70.1 (Michaël Zasso) #406583bfc9f5b47] - doc: add information on suppressing initial break in debugger (Rich Trott) #409608966ab3c57] - doc: improve grammar in API description (Tobias Nießen) #40959130777a61c] - doc: update BUILDING.md section on running tests (Rich Trott) #409336e9b6652e5] - doc: remove experimental abortcontroller flag (FrankQiu) #38968b92416ff02] - doc: fix spelling of 'WebAssembly' (Geoffrey Booth) #40785cf495a6293] - doc: clarify more optional parameters in node-api (Michael Dawson) #40888694012b392] - doc: define "types", "deno" community conditions (Guy Bedford) #407084c47b0150b] - doc: document optional params in napi_get_cb_info (Michael Dawson) #40821dfdf68f4d0] - doc: improve README.md lede section (Rich Trott) #408379c200e1de4] - doc: add pref to using draft PR versus WIP label (Michael Dawson) #40824fe2cd09750] - doc: fixadded:info forReadable.fromWeb()(Luigi Pinca) #40820c91a9ab095] - doc: tweak guidance for modules in core (Michael Dawson) #406012ea08e9b55] - doc: claim ABI version for Electron 18 (Keeley Hammond) #407688166b07ddc] - doc: fix transform stream example (Evan Lucas) #407775ceb06cddf] - doc: fix linter-enforced formatting in crypto.md (Mohammed Keyvanzadeh) #40780d3070d8eea] - doc: fix corepack grammar for--forceflag (Steven) #407629271f23e3a] - doc: update maintaining ICU guide (Michaël Zasso) #4065820d7d657bb] - doc: clarify getAuthTag with authTagLength (Tobias Nießen) #4071375288fbc6b] - doc: fix order of announce work (Michael Dawson) #40725429915aa6c] - doc: add initial list of technical priorities (Michael Dawson) #40235a5a1691514] - fs: nullish coalescing to respect zero positional reads (Omar El-Mihilmy) #40716bddb4c69b7] - http: add missing initialization (Michael Dawson) #4055580ce97f514] - http: change totalSocketCount only on socket creation/close (Subhi Al Hasan) #40572675c210b04] - (SEMVER-MINOR) lib: add reason to AbortSignal (James M Snell) #40807b614b17525] - Revert "lib: use helper for readability" (Darshan Sen) #4074110a842d2d1] - lib: fix typos in lib code comments (Yoshiki) #407923ec78d1570] - meta: add feature request label for issue template (Mestery) #409709c897b69a1] - meta: update AUTHORS (Node.js GitHub Bot) #40900dfc6fc987a] - meta: update name and email (Viero Fernando) #40848813cf746a8] - meta: update AUTHORS (Node.js GitHub Bot) #40809e451ec9ec1] - meta: edit GOVERNANCE.md for minor updates (Rich Trott) #407982536be7528] - meta: update AUTHORS (Node.js GitHub Bot) #407483c8aa211cd] - module: import assertions improvements (Geoffrey Booth) #407853a4f3873be] - process: support hrtime in the snapshot (Joyee Cheung) #406491555dbdddc] - repl: fix and extend require/import tab complete (Mestery) #40216c2259c974b] - src: reset error struct if error code is napi_ok (JckXia) #405523be49d6853] - src: prevent extra copies ofTimerWrap::TimerCb(Darshan Sen) #406650de2850680] - (SEMVER-MINOR) src: add x509.fingerprint512 to crypto module (3nprob) #39809924d29e88f] - src: add and fix some preprocessor comments (Tobias Nießen) #40701acbd8220a7] - src,crypto: useByteSource::ToBuffer()incrypto_dh(Darshan Sen) #4090382b422663d] - src,crypto: removeAllocatedBuffers fromcrypto_spkac(Darshan Sen) #40752415b42fbdf] - src,crypto: refactorcrypto_tls.*(Darshan Sen) #4067588b57bc9d3] - src,doc: add SyntaxError napi support (Idan Attias) #4073670bd90e039] - stream: stricter isReadableNodeStream (Robert Nagy) #4094186d1c0b19d] - stream: drain Transform with 0 highWaterMark (Robert Nagy) #40947fa9b5c35d2] - stream: deprecate thenable support (Antoine du Hamel) #40860dc99ae3bd6] - stream: fix the ReadableStreamBYOBReader error message (James M Snell) #40846650c9bd022] - stream: pipeline with end option (Robert Nagy) #40886534409d4e7] - stream: fix finished regression when working with legacy Stream (Matteo Collina) #4085816ee8423d6] - stream: pipeline should drain empty readable (Robert Nagy) #406547d127d2fc1] - stream: fix non readable Duplex readableAborted (Robert Nagy) #408017c4f9a34ae] - stream: allow calling callback before promise (Robert Nagy) #4077262171eb516] - test: mark test-fs-watch-non-recursive flaky on Windows (Luigi Pinca) #40916ae12a609a5] - test: improve test coverage of readline/promises (Yoshiki Kurihara) #408764288c6a26e] - test: deflake cluster-concurrent-disconnect (Luigi Pinca) #40877009ab4d9bb] - test: deflake fs-promises-watch (Luigi Pinca) #40863522a30f469] - test: fix argument order in assertion (Luigi Pinca) #40842b190b0e77b] - test: deflake http2-pipe-named-pipe (Luigi Pinca) #40842c485460793] - test: use descriptive name for destination file (Luigi Pinca) #4084243e86508ae] - test: add AsyncLocalStorage tests using udp, tcp and tls sockets (Darshan Sen) #40741896073be47] - test: deflake child-process-pipe-dataflow (Luigi Pinca) #40838150c0f1b76] - test: add tests for invalid UTF-8 (git-srinivas) #403513d896231cd] - test: fix flaky test-policy-integrity (Rich Trott) #40763dc9e68899d] - test: add semicolons for linter update (Rich Trott) #40720747247bc59] - tools: update gyp-next to v0.10.1 (Michaël Zasso) #409346ebbd0d9dc] - tools: fix commit-lint GH Actions CI (Antoine du Hamel) #408450201f3f604] - tools: ping TSC members identified as inactive (Rich Trott) #4091522265e3fb6] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #409293d593aa4ed] - tools: update lint-md dependencies (Rich Trott) #40894e674f61720] - tools: update ESLint to 8.3.0 (Luigi Pinca) #40917878ba91bf6] - tools: add find-inactive-tsc (Rich Trott) #40884d97ad3080f] - tools: disable trap handler for Windows cross-compiler (Michaël Zasso) #40488e3f8988118] - tools: update V8 gypfiles for 9.6 (Michaël Zasso) #40488de4d0180dc] - tools: update @babel/eslint-parser to 7.16.3 (Node.js GitHub Bot) #40889727b34ec95] - tools: only validate first commit message of a PR (Antoine du Hamel) #407405b08e908ea] - tools: update babel-eslint-parser to 7.16.0 (Rich Trott) #4072030623c283a] - tools: improve update scripts (Rich Trott) #40644