-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: ping TSC members identified as inactive #40915
Conversation
If we want to 100% make sure this works, we can fast-track it, close #40908, and let this open a PR. |
This lgtm, but it was mostly the next part of the message that I was interested in automating:
|
OK, I think this does something like that now. (I haven't tested it via an Action yet, but will run it when it lands and revise if necessary.) |
When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error.
Landed in f7ac6ba |
https://github.com/nodejs/node/runs/4315947355?check_suite_focus=true
The only nit would be to get rid of the |
I wonder if spaces aren't a problem in single-line |
I don't know for |
And if all else fails, we can use the multi-line HEREDOC format they support which doesn't require quotation marks or other punctuation around spaces. |
(Testing now on my fork.) |
Yup, leaving out the quotation marks worked. https://github.com/Trott/io.js/runs/4318829465?check_suite_focus=true (The failure is because I didn't set a needed token on my fork.) PR coming momentarily. |
Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error. PR-URL: #40915 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error. PR-URL: #40915 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error. PR-URL: #40915 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.