stream: fix non readable Duplex readableAborted

PR-URL: #40801 Fixes: #40800 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Nov 21, 2021 · 7d127d2 · 7d127d2
1 parent e451ec9
commit 7d127d2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/lib/internal/streams/readable.js b/lib/internal/streams/readable.js
@@ -1187,8 +1187,11 @@ ObjectDefineProperties(Readable.prototype, {
   readableAborted: {
     enumerable: false,
     get: function() {
-      return !!(this._readableState.destroyed || this._readableState.errored) &&
-        !this._readableState.endEmitted;
+      return !!(
+        this._readableState.readable !== false &&
+        (this._readableState.destroyed || this._readableState.errored) &&
+        !this._readableState.endEmitted
+      );
     }
   },
 

diff --git a/test/parallel/test-stream-readable-aborted.js b/test/parallel/test-stream-readable-aborted.js
@@ -2,7 +2,7 @@
 
 const common = require('../common');
 const assert = require('assert');
-const { Readable } = require('stream');
+const { Readable, Duplex } = require('stream');
 
 {
   const readable = new Readable({
@@ -55,3 +55,12 @@ const { Readable } = require('stream');
   }));
   readable.resume();
 }
+
+{
+  const duplex = new Duplex({
+    readable: false,
+    write() {}
+  });
+  duplex.destroy();
+  assert.strictEqual(duplex.readableAborted, false);
+}