-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: patch V8 to 7.4.288.27 #27615
deps: patch V8 to 7.4.288.27 #27615
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This seems to be failing in the v8 ci: v8-updates/test-linux-perf |
The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue.
This comment has been minimized.
This comment has been minimized.
CI: https://ci.nodejs.org/job/node-test-pull-request/23015/ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber Stamp LGTM
The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue. PR-URL: nodejs#27615 Refs: v8/v8@7.4.288.21...7.4.288.27 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: v8/v8@7.4.288.21...7.4.288.27 PR-URL: nodejs#27615 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Landed in 556de23...95c1cb4 I put the test fix commit first and the V8 update commit second so that there wasn't a commit where the test isn't robust (or at least believed to be robust). |
The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue. PR-URL: #27615 Refs: v8/v8@7.4.288.21...7.4.288.27 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: v8/v8@7.4.288.21...7.4.288.27 PR-URL: #27615 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Rich Trott <[email protected]>
The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue. PR-URL: #27615 Refs: v8/v8@7.4.288.21...7.4.288.27 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: v8/v8@7.4.288.21...7.4.288.27
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes