-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: V8: backport d915b8d #27481
deps: V8: backport d915b8d #27481
Conversation
This commit landed upstream last week, so it's not in 7.4 or 7.5. This will fix #27346. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks like it needs to be adapted:
|
Yep, I'm working on it. |
Original commit message: [snapshot] Fix copy-IET integration with Code Cache [email protected], [email protected], [email protected] Bug: v8:9122 Change-Id: I6336d2fc0249269a749d99dcae7c172b2ccaac75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570582 Reviewed-by: Jakob Gruber <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/master@{#60937} Refs: v8/v8@d915b8d
2a4e5bf
to
8336291
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I assume V8 7.4 or at least 7.5 is still a supported release line on the V8 side? Should there be a merge request for this? |
Yes, I opened a merge request as well (https://bugs.chromium.org/p/v8/issues/detail?id=9122#c9). Hopefully we won't need to have a floating patch to fix this. |
I think we'll get this merged to 7.4 and 7.5 in the next few days, so blocking this for now. |
Superseded by #27615 |
Original commit message:
Refs: v8/v8@d915b8d
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes