Skip to content

Commit

Permalink
test: fix test-linux-perf flakiness
Browse files Browse the repository at this point in the history
The new V8 seems to be optimizing the functions we use in this test
faster than before. Increasing the sampling frequency for Linux perf
fixes the issue.

PR-URL: nodejs#27615
Refs: v8/v8@7.4.288.21...7.4.288.27
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
  • Loading branch information
mmarchini authored and Trott committed May 10, 2019
1 parent 556de23 commit 3b2633e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/v8-updates/test-linux-perf.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (process.config.variables.node_shared)

const perfArgs = [
'record',
'-F500',
'-F999',
'-g',
'--',
process.execPath,
Expand Down

0 comments on commit 3b2633e

Please sign in to comment.