Release Proposal: v3.1.0 #2347
Release Proposal: v3.1.0 #2347
Conversation
Fishrock123
added
the
meta
|
Do we want extra metadata on the cherry-picked commits or not? I may look into how much work making some tooling for it would be.. |
|
For the interested, made via this command, since there is nothing semver-major past 4.0.0 bump on master: |
I don't see a case for this, unless you have something in mind? Also, let's not assume that everything that's not semver-major goes into a release, the list is fine for now but we're going to need to deal with awkward subtleties in the future. |
|
847459c was landed as a major to master? |
|
@brendanashworth that commit isn't listed here. :) |
|
Also +1 for something like #2352. @Fishrock123 does that mean you're cutting the release before that commit? |
|
@silverwind No, this list was the applicable commits at the time this PR was created, I'll update it as we get closer. |
|
+1 for holding off till the memory leaks are fixed, I'd consider 3.0.0 somewhat broken until we have that sorted out |
|
Could we add these two?
|
|
@srl295 I'm willing to hold it for the memory leak fixes, but the rest will have to just come as they land; there will probably be weekly-ish releases from stable lines still. |
|
@Fishrock123 No reason to hold. #2292 is ready to merge. |
|
@Fishrock123 Can you include 2781333 - converged Intl? #238 |
|
Added: |
|
@Fishrock123 The memory leak PR is up, reviewed and green (#2352). I usually leave contributors to merge their own PR's, but if it's a hurry then it's probably fine to land now. |
|
#2352 just landed in 2781333...8841947. |
|
I'll try to write a changelog soon, but #2375 also looks promising for plugging mem leaks. |
|
One problem with not cherry-picking regularly and letting them bunch up until a release is that we don't get nightlies for the stable branches except when we also get a release. This is something we're going to have to figure out a process for. In the meantime, because I want a nightly that I can do some memory testing from, I've cherry-picked the latest, excluding the version bump and the semver-major. The commit log looks like this now:
@Fishrock123: FYI changelog-maker is getting an upgrade to handle the GH API redirects for nodejs/io.js -> nodejs/node (yay for API redirects!) but the patch process is snaking its way through various modules that I need collaborator signoff on (jsonist -> ghutils -> ghissues -> changelog-maker), should be ready soon but the above is the non-grouped result of running it on v3.x. |
|
Here's the nightly: https://iojs.org/download/nightly/v3.0.1-nightly201508173645dc62ed/ I'll report back if I find anything re memory but don't let that hold up a release since it appears that we have the major issues sorted out. At a glance it doesn't look like #2375 is dealing with anything v3 specific and they mostly look like one-off minor non-frees anyway. |
|
^ |
|
@rvagg Why do we have the (SEMVER-MINOR) label? With the new way the branches are managed I'm missing the utility in it. |
|
@trevnorris making it easier for us to know when to bump minors in the stable branch. :) |
|
@Fishrock123 yeah... very obvious now. thanks. |
|
@trevnorris |
|
Sorry it's been longer, will try to get this out tomorrow morning. |
|
CI: https://jenkins-iojs.nodesource.com/job/node-test-commit/186/ Edit: fixed. |
|
changelog-maker is now updated and follows GitHub API redirects to get the PR labels properly, update your copy @Fishrock123 |
New CI: https://jenkins-iojs.nodesource.com/job/node-test-commit/191/ |
Notable changes: * buffer: Fixed a couple large memory leaks (Ben Noordhuis) nodejs#2352. * crypto: - Fixed a couple of minor memory leaks (Karl Skomski) nodejs#2375. - Signing now checks for OpenSSL errors (P.S.V.R) nodejs#2342. **Note that this may expose previously hidden errors in user code.** * intl: Intl using small-icu is now enabled by default in builds (Steven R. Loomis) nodejs#2264. - `String#normalize()` can now be used for unicode normalization. - The `Intl` object and various `String` and `Number` methods are present, but only support the English locale. - For support of all locales, node must be built with full-icu. * tls: Fixed tls throughput being much lower after an incorrect merge (Fedor Indutny) nodejs#2381. * tools: The v8 tick processor now comes bundled with node (Matt Loring) nodejs#2090. - This can be used by producing performance profiling output by running node with `--perf`, then running your appropriate platform's script on the output as found in https://github.com/nodejs/node/tree/master/tools/v8-prof. * util: `util.inspect(obj)` now prints the constructor name of the object if there is one (Christopher Monsanto) nodejs#1935. PR-URL: nodejs#2347
PR-URL: nodejs#2347
|
|
Crap. I just noticed all the changelog dates say the 18th (yesterday)... Building as the 19th.. hope it doesn't matter: https://jenkins-iojs.nodesource.com/job/iojs+release/76/ |
|
Slight issue with the Changelog from http://iojs.org/ |
Notable changes: * buffer: Fixed a couple large memory leaks (Ben Noordhuis) nodejs#2352. * crypto: - Fixed a couple of minor memory leaks (Karl Skomski) nodejs#2375. - Signing now checks for OpenSSL errors (P.S.V.R) nodejs#2342. **Note that this may expose previously hidden errors in user code.** * intl: Intl using small-icu is now enabled by default in builds (Steven R. Loomis) nodejs#2264. - `String#normalize()` can now be used for unicode normalization. - The `Intl` object and various `String` and `Number` methods are present, but only support the English locale. - For support of all locales, node must be built with full-icu. * tls: Fixed tls throughput being much lower after an incorrect merge (Fedor Indutny) nodejs#2381. * tools: The v8 tick processor now comes bundled with node (Matt Loring) nodejs#2090. - This can be used by producing performance profiling output by running node with `--perf`, then running your appropriate platform's script on the output as found in https://github.com/nodejs/node/tree/master/tools/v8-prof. * util: `util.inspect(obj)` now prints the constructor name of the object if there is one (Christopher Monsanto) nodejs#1935. PR-URL: nodejs#2347 Conflicts: src/node_version.h
PR-URL: nodejs#2347
|
@alexlamsl see #2448 :s |
The usual weekly-ish. Less chun than usual due to collab summit and major bump. I think the
util._inspectthing is semver-minor.9f43202114] - build: work around VS2015 issue in ICU <56 (Steven R. Loomis) nodejs/node#228376c7158b2e] - (SEMVER-MINOR) build: intl: converge from joyent/node (Steven R. Loomis) nodejs/node#2264a3798a32d9] - build: Intl: bump ICU4C from 54 to 55 (Steven R. Loomis) nodejs/node#22933a48c7220e] - build: update manifest to include Windows 10 (Lucien Greathouse) #23320bb099f444] - build: expand ~ in install prefix early (Ben Noordhuis) #23071eef5473e2] - crypto: check for OpenSSL errors when signing (P.S.V.R) nodejs/node#2342e80a81a13c] - crypto: fix memory leak in PBKDF2Request (Karl Skomski) nodejs/node#2375eb43086ef5] - crypto: fix memory leak in ECDH::SetPrivateKey (Karl Skomski) nodejs/node#23752709435f46] - crypto: fix memory leak in PublicKeyCipher::Cipher (Karl Skomski) nodejs/node#23756b7df3c89b] - crypto: fix memory leak in SafeX509ExtPrint (Karl Skomski) nodejs/node#23757b0a354cc4] - crypto: fix memory leak in SetDHParam (Karl Skomski) nodejs/node#23752f154b52da] - doc: multiple documentation updates cherry picked from v0.12 (James M Snell) #23026f89de9c9a] - net: ensure Socket reported address is current (Ryan Graham) #20953db098f1ea] - path: use '===' instead of '==' for comparison (Sam Stites) nodejs/node#23884750a2af19] - path: remove dead code in favor of unit tests (Nathan Woltman) #22826e3f64abf7] - src: better error message on failed Buffer malloc (Karl Skomski) nodejs/node#242236e0d766a6] - src: fix memory leak in DLOpen (Karl Skomski) nodejs/node#23753855460931] - src: don't use fopen() in require() fast path (Ben Noordhuis) nodejs/node#23774ea6bddc03] - src: rename Buffer::Use() to Buffer::New() (Ben Noordhuis) nodejs/node#23523c46e237c7] - src: introduce internal Buffer::Copy() function (Ben Noordhuis) nodejs/node#2352fdd1052232] - src: move internal functions out of node_buffer.h (Ben Noordhuis) nodejs/node#2352f775aac0b7] - src: plug memory leaks (Ben Noordhuis) nodejs/node#2352a5dd67bd81] - (SEMVER-MINOR) src: add total_available_size to v8 statistics (Roman Klauke) #23482d1d63e9fe] - test: correct spelling of 'childProcess' (muddletoes) nodejs/node#23897e5fc74a4c] - test: option to run a subset of tests (João Reis) #2260bed03ea143] - test: clarify dropMembership() call (Rich Trott) #20626ef7aea587] - test: make listen-fd-cluster/server more robust (Sam Roberts) #1944c8282de860] - test: address timing issues in simple http tests (Gireesh Punathil) #2294988f0f9476] - tls: fix throughput issues after incorrect merge (Fedor Indutny) nodejs/node#2381581850b10c] - tls: fix check for reused session (Fedor Indutny) #231251b6bdcb49] - tls: introduce internalonticketkeycallback(Fedor Indutny) #23121af1b4ba1b] - (SEMVER-MINOR) tools: run the tick processor without building v8 (Matt Loring) nodejs/node#2090ee9dd683e5] - (SEMVER-MINOR) util: display constructor when inspecting objects (Christopher Monsanto) #1935cc @nodejs/tsc