crypto: fix memory leak in ECDH::SetPrivateKey

PR-URL: #2375 Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Aug 19, 2015 · ba6eb8a · ba6eb8a
1 parent 6a16368
commit ba6eb8a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -4568,8 +4568,12 @@ void ECDH::SetPrivateKey(const FunctionCallbackInfo<Value>& args) {
   if (priv == nullptr)
     return env->ThrowError("Failed to convert Buffer to BN");
 
-  if (!EC_KEY_set_private_key(ecdh->key_, priv))
+  int result = EC_KEY_set_private_key(ecdh->key_, priv);
+  BN_free(priv);
+
+  if (!result) {
     return env->ThrowError("Failed to convert BN to a private key");
+  }
 }