Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v10.11.0 #22932

Merged
merged 107 commits into from
Sep 20, 2018
Merged

Release proposal: v10.11.0 #22932

merged 107 commits into from
Sep 20, 2018

Conversation

targos
Copy link
Member

@targos targos commented Sep 18, 2018

2018-09-20, Version 10.11.0 (Current), @targos

Notable Changes

  • fs
    • Fixed fsPromises.readdir withFileTypes. #22832
  • http2
    • Added http2stream.endAfterHeaders property. #22843
  • util
    • Added util.types.isBoxedPrimitive(value). #22620
  • Added new collaborators:
  • The Technical Steering Committee has new members:

Commits

  • [add1fcd301] - assert: add default operator to assert.fail() (Ruben Bridgewater) #22694
  • [0015430b2c] - assert: align argument names (Ruben Bridgewater) #22760
  • [3fcd54fe46] - build: do not lint fixtures in make lint-md (Joyee Cheung) #22549
  • [84d498c044] - build: skip cctest on Windows shared lib build (Yihong Wang) #21228
  • [3ff425e7e9] - build: remove /MP from default additonal options (William Skellenger) #22661
  • [a78a946648] - build: make doc generation work on Windows (Tobias Nießen) #22749
  • [5bae8b9728] - build: add --verbose to ./configure (Refael Ackermann) #22450
  • [db10db9e18] - build: move meta-shebang back to configure (Refael Ackermann) #22450
  • [db52f8f913] - build: rename configure to configure.py (Refael Ackermann) #22450
  • [b4a79acd98] - build,win: exclude warning 4244 only for deps (Refael Ackermann) #22698
  • [dbe27d7c80] - build,win: generate single PDB file per target (Refael Ackermann) #22698
  • [b3bc642d96] - build,win: WHOLEARCHIVE needs just lib name (Refael Ackermann) #22698
  • [624e516fb7] - crypto: fix edge case in authenticated encryption (Tobias Nießen) #22828
  • [329ac60441] - crypto: remove unused scrypt validation parameter (Tobias Nießen) #22902
  • [9b58b79372] - crypto: rename symbols to match guidelines (Tobias Nießen) #22770
  • [ff17b39008] - crypto: fix public key encryption internals (Tobias Nießen) #22780
  • [566075967d] - deps: cherry-pick 9a23bdd from upstream V8 (Daniel Beckert) #22910
  • [bb3292fd1f] - deps: add missing HandleScope in FieldType::PrintTo (Yang Guo) #22890
  • [967fbebf47] - deps: cherry-pick 2363cdf from upstream V8 (Ali Ijaz Sheikh) #22812
  • [e85aa19a82] - deps: patch V8 to 6.8.275.32 (Michaël Zasso) #22682
  • [6a333999cf] - deps: backport detailed line info for CPU profiler (Peter Marshall) #22688
  • [6ed58457e2] - doc: explain how to invoke gc (isurusiri) #20431
  • [6e9f1d6d08] - doc: add boneskull as collaborator (Christopher Hiller) #22917
  • [f0679d9b24] - doc: update 6.x to 8.x in backporting wiki (Kamat, Trivikram) #22879
  • [5c5d881beb] - doc: improve asymmetric crypto docs (Anna Henningsen) #22820
  • [0873d0abfb] - doc: add missing options for crypto sign.sign() (Mohit kumar Bajoria) #22824
  • [08e427afea] - doc: add full deprecation history (Tobias Nießen) #22766
  • [ed142e1355] - doc: add withFileTypes option to fsPromises.readdir (Bryan English) #22833
  • [8e8748c329] - doc: fix typo in dns docs (Mohammed Essehemy) #22866
  • [cadb3606f8] - doc: update AUTHORS list (Anna Henningsen) #22771
  • [0c39fa4240] - doc: add reference to guide for N-API additions (Michael Dawson) #22593
  • [ef2a0bdc2e] - doc: document http2 timeouts (Sagi Tsofan) #22798
  • [cf95b61ad5] - doc: add gabrielschulhof to TSC (Rich Trott) #22818
  • [678673098f] - doc: add history for withFileTypes in fs.readdir[Sync]() (Tien Do) #22794
  • [bda3311afe] - doc: node debugnode inspect in CLI docs (Anna Henningsen) #22774
  • [9942117e6e] - doc: update mmarchini's e-mail (Matheus Marchini) #22776
  • [6579d05b15] - doc: fix description of DEP0024 (Tobias Nießen) #22755
  • [c1c78ca4eb] - doc: improve assert documentation (Ruben Bridgewater) #22692
  • [e5cdfb0856] - doc: fix typo in CHANGELOG_V10.md (Chakravarthy S M) #22744
  • [2b49b43f79] - doc: added symbols guidelines (Matteo Collina) #22684
  • [688d01c7be] - doc: add warning to readline's close() method (cjihrig) #22679
  • [47acb78528] - doc: add apapirovski to TSC (Rich Trott) #22717
  • [5da1f0ca2c] - doc, win: improve os.setPriority documentation (Bartosz Sosnowski) #22817
  • [d69d06bbf7] - errors: add useOriginalName to internal/errors (Joyee Cheung) #22556
  • [2cb01f0d12] - errors: decapitalize PBKDF2 error (Tobias Nießen) #22687
  • [24a35f914a] - fs: fix promisified fs.readdir withFileTypes (Anatoli Papirovski) #22832
  • [f0a40172a8] - fs: ensure readdir() callback is only called once (cjihrig) #22793
  • [790864bf9b] - (SEMVER-MINOR) http2: add http2stream.endAfterHeaders property (James M Snell) #22843
  • [2abdbf4368] - lib: generate allowedNodeEnvironmentFlags lazily (Anna Henningsen) #22638
  • [49b59334d0] - lib: simplify 'processChunkSync' (MaleDong) #22802
  • [e2b72c2ca3] - lib: remove unnecessary symbols (MaleDong) #22455
  • [25220f0ce1] - lib,doc: remove unused parameter, improve docs (MaleDong) #22858
  • [bb2bbc8ebe] - n-api: add generic finalizer callback (Gabriel Schulhof) #22244
  • [4e3f1aef8d] - net: port isIPv6 to JS (Weijia Wang) #22673
  • [5c8495349a] - path: remove unnecessary if statement (William Chargin) #22273
  • [4ab9d6f3db] - process: generate list of allowed env flags programmatically (Anna Henningsen) #22638
  • [5d5c3fab25] - src: refactor Environment::GetCurrent() usage (Anna Henningsen) #22819
  • [5a494aed8c] - src: move no_async_hooks_checks to env (Daniel Bevenius) #22784
  • [bc076120f3] - src: fix --prof-process CLI argument handling (Anna Henningsen) #22790
  • [7e4f29f201] - src: move DebugPortGetter/Setter to node_process.cc (James M Snell) #22758
  • [1d3a63f079] - src: move getActiveResources/Handles to node_process.cc (James M Snell) #22758
  • [0c3242862a] - src: make FIXED\_ONE\_BYTE\_STRING an inline fn (Anna Henningsen) #22725
  • [7fa5f54e6f] - src: remove trace_sync_io_ from env (Daniel Bevenius) #22726
  • [c3c5141f68] - src: remove abort_on_uncaught_exception node.cc (Daniel Bevenius) #22724
  • [44f1438b79] - src: fix trace-event-file-pattern description (Andreas Madsen) #22690
  • [a10d03d4fe] - string_decoder: support typed array or data view (Benjamin Chen) #22562
  • [ff6e4ea4bd] - test: prepare test-assert for strictEqual linting (Rich Trott) #22849
  • [5a0632666b] - test: remove string literal from assertion (Rich Trott) #22849
  • [5d4cbd7fa1] - test: remove string literal from assertion (Rich Trott) #22849
  • [5316334955] - test: remove string literal arg from assertion (Rich Trott) #22849
  • [59b6968fb6] - test: remove string literal message from assertion (Rich Trott) #22849
  • [266f1a9cd8] - test: remove string literal from assertion (Rich Trott) #22849
  • [a5f7f1d985] - test: refactor flag check (Rich Trott) #22849
  • [e5de225680] - test: simplify assertion in http2 tests (Rich Trott) #22849
  • [b31a4d0808] - test: improve assertion in test-inspector.js (Rich Trott) #22849
  • [b301a7b7ec] - test: remove string literal message in assertions (Rich Trott) #22849
  • [a15bfdad78] - test: remove string literal message from assertion (Rich Trott) #22849
  • [e580a44ab6] - test: don't inspect values if not necessary (Ruben Bridgewater) #22903
  • [9e1f7366db] - test: minor refactor in common/index.js (James M Snell) #22738
  • [bd6b2ab21d] - test: checks on napi factory wrap’s finalization (Lucas Woo) #22612
  • [b1d667bca9] - test: refactor structure of common/index (James M Snell) #22511
  • [d5e9801d8d] - test: remove string literal from deepStrictEqual (iliashkolyar) #22742
  • [649288bef6] - test: remove string argument to strictEqual() (Hariss096) #22718
  • [36666629f6] - test: replaces assert.throws() with common.expectsError() (Saud Khanzada) #22689
  • [13b8011589] - test: remove usage of deprecated V8 APIs in addons (Michaël Zasso) #22704
  • [1ce94164a5] - test: fix flaky addons/callback-scope/test-resolve-async (Anna Henningsen) #22664
  • [6367349a95] - tools: synchronize deepStrictEqual() message rules (Rich Trott) #22887
  • [8ffcb2d2ca] - tools: prevent string literals in some assertions (Rich Trott) #22849
  • [4ff49ae81c] - tools: merge custom cpplint with cpplint v1.3.0 (Christopher Hiller) #22864
  • [15a59bb2b2] - tools: update ESLint to 5.6.0 (Rich Trott) #22882
  • [b2abeff43c] - tools: implement update-authors in JS (Anna Henningsen) #22771
  • [9564f7a123] - tools: fix doc tool behavior for version arrays (Tobias Nießen) #22766
  • [d03ce9df05] - tools: use lint-md.js (Refael Ackermann) #20109
  • [22fefaeeeb] - tools: make lint-md-rollup & checkin lint-md.js (Refael Ackermann) #20109
  • [350a3e17f5] - tools: relocate remark-preset-lint-node (Refael Ackermann) #20109
  • [25e1060ce4] - tools: update node-lint-md-cli-rollup (Refael Ackermann) #20109
  • [37b27a5604] - tools: vendor in node-lint-md-cli-rollup (Refael Ackermann) #20109
  • [62d73042c6] - tools: update eslint to v5.5.0 (Ruben Bridgewater) #22720
  • [a7e8949cb7] - tools: add [src] links to child-process.html (Sam Ruby) #22706
  • [ca06e65b08] - tools: update dmn to 2.0.0 (Rich Trott) #22733
  • [649fcbba6f] - tools,doc: apilinks should handle root scenarios (Kyle Farnung) #22721
  • [0fc79d48f8] - tools,win: fix find_python error (Kyle Farnung) #22797
  • [aa05c8b117] - trace_events: avoid flusing uninitialized traces (Ali Ijaz Sheikh) #22812
  • [db7927683c] - tracing: remove shutdown-on-signal (Anna Henningsen) #22734
  • [8cfa88aa5c] - (SEMVER-MINOR) util: add util.types.isBoxedPrimitive (Ruben Bridgewater) #22620
  • [a96a8468d6] - worker: correct (de)initialization order (Anna Henningsen) #22773

BridgeAR and others added 30 commits September 7, 2018 00:11
Checking all boxed primitives individually requires to cross the C++
barrier multiple times besides being more complicated than just a
single check.

PR-URL: #22620
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #22717
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
New version of dmn with better support for case-sensitive file systems.
Use it in the update-* scripts.

PR-URL: #22733
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
When close() is called on a readline instance, it is possible
that data is already buffered, and will trigger 'line' events.
This commit adds a warning to the corresponding docs. Note that
a similar warning already exists for the pause() method.

PR-URL: #22679
Fixes: #22615
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
[cpu-profiler] Add flag to always generate accurate line info.
https://chromium.googlesource.com/v8/v8/+/
56baf56790de439b3f69e887e94beb3b301ed77c

[cpu-profiler] Turn on detailed line info for optimized code
https://chromium.googlesource.com/v8/v8/+/
84894ce6d2af7feb9e1f5574409355120887326c

[cpu-profiler] Separate the flags for generating extra line information
https://chromium.googlesource.com/v8/v8/+/
30ff6719db441cc7ef220d449970cc169067e256

PR-URL: #22688
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #22687
Refs: #20816
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #22684
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Fixes: #22668
PR-URL: #22664
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #22690
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #22682
Refs: v8/v8@6.8.275.30...6.8.275.32
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #22704
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
!Should go with next commit!

* renaming so that IDEs can properly detect this as python
* Add dependency to Makefile

PR-URL: #22450
Reviewed-By: Joyee Cheung <[email protected]>
Fix typo

PR-URL: #22744
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
This fixes the officially accepted message types for `assert.throws()`,
`assert.rejects()`, `assert.doesNotThrow()` and
`assert.doesNotReject()`. It also renames the `block` argument in
those functions to `fn` and `promiseFn` for further clarity.

PR-URL: #22692
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: George Adams <[email protected]>
PR-URL: #22749
Refs: #21697
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #22755
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
handle exports. as an alternative to module.exports

PR-URL: #22706
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
replaces assert.throws() with common.expectsError() to check error code
and error type in parallel/test-buffer-alloc.js

PR-URL: #22689
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This commit removes the static variable abort_on_uncaught_exception and
adds it to the environment options.

PR-URL: #22724
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Removing string literal passed as argument to assert.strictEqual() in
order to print the expected value instead of the string. (First issue
assigned through Email by Rich Trott)

PR-URL: #22718
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This commit removes trace_sync_io_ and instead uses the options value
directly.

PR-URL: #22726
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #22661
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
PR-URL: #22776
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
* Prevent crash when setting root properties
* Allow return outside of function

PR-URL: #22721
Reviewed-By: Sam Ruby <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #22742
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
This prevents accidental usage on non-fixed strings.

PR-URL: #22725
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Porting isIPv6() to JS makes it 10%-250% faster in most cases and
reduces some C++ code. This change also adds tests for some edge
cases.

PR-URL: #22673
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
PR-URL: #22720
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Trott and others added 16 commits September 20, 2018 08:09
Remove an unecessary string literal from assert.strictEqual() call in
test-inspector.js. The string literal is printed instead of the value
that causes an error. Removing the string literal allows the value that
caused the error to be printed. This improves the troubleshooting
experience when the test fails due to that assertion.

Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
In test-http2-timeout-large-write.js and
test-http2-timeout-large-write-file.js:

Use assert.ok() on a boolean that the test itself creates and sets,
rather than assert.strictEqual(). This allows us to use a static message
without running afoul of the upcoming "do not use string literals with
assert.strictEqual()" lint rule.

Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Refactor test-vm-run-in-new-context so that check for `--expose-gc` flag
will not run afoul of an upcoming lint rule that checks that string
literals are not used for the `message` argument of
`assert.strictEqual()`.

Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Remove string literal from `assert.strictEqual()` call `message`
parameter and make it a comment above the assertion instead.

Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Remove string literal from assert.strictEqual message to improve output
of AssertionError.

Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Remove unnecessary string literal from assert.deepStrictEqual() call.

Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Remove string literal as assertion message in call to
assert.strictEqual() in test-dns-resolveany-bad-ancount.

Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Remove string literal as assertion message in call to
assert.strictEqual() in test-dns-lookup.

Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Make minor modifications to test-assert.js to prepare it for linting
rule that forbids the use of string literals for the third argument of
assert.strictEqual().

Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
String literals provided as the third argument to assert.strictEqual()
or assert.deepStrictEqual() will mask the values that are causing
issues. Use a lint rule to prevent such usage.

Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Original commit message:

    [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames

    Previously we were getting the code object from the stack, so printed incorrect
    position details for interpreted frames.

    BUG=v8:7916

    Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
    Reviewed-on: https://chromium-review.googlesource.com/1126313
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Ross McIlroy <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#54253}

Refs: v8/v8@9a23bdd
Refs: #21988
PR-URL: #22910
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
1) Remove 'callback' in 'check' function, because we don't check or use
that directly.

2) Make 'digest' clearer in the documentation.

PR-URL: #22858
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Update ESLint config to include a rule about assert.deepStrictEqual()
messages and string literals. The rule is included in lib and test, but
should be included everywhere else as well.

PR-URL: #22887
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Currently the documentation for Wrapping C++ Objects doesn't explain
how to destruct an object by explicitly invoking the garbage collector.
This commit includes a modification to docs that explains how to force
the garbage collector to clear objects using V8's command line flags.

Fixes: #19876

PR-URL: #20431
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
PR-URL: #22817
Fixes: #22799
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Notable changes:

* fs
  * Fixed fsPromises.readdir `withFileTypes`.
    #22832
* http2
  * Added `http2stream.endAfterHeaders` property.
    #22843
* util
  * Added `util.types.isBoxedPrimitive(value)`.
    #22620
* Added new collaborators:
  * boneskull (https://github.com/boneskull) - Christopher Hiller
* The Technical Steering Committee has new members:
  * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski
  * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof

PR-URL: #22932
@targos
Copy link
Member Author

targos commented Sep 20, 2018

@targos targos dismissed Trott’s stale review September 20, 2018 06:29

Recursive mkdir has been removed

@targos
Copy link
Member Author

targos commented Sep 20, 2018

@targos
Copy link
Member Author

targos commented Sep 20, 2018

Everything is ready to proceed on my end.
Could anyone please review the latest release commit?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos merged commit 8c70b20 into v10.x Sep 20, 2018
targos added a commit that referenced this pull request Sep 20, 2018
targos added a commit that referenced this pull request Sep 20, 2018
Notable changes:

* fs
  * Fixed fsPromises.readdir `withFileTypes`.
    #22832
* http2
  * Added `http2stream.endAfterHeaders` property.
    #22843
* util
  * Added `util.types.isBoxedPrimitive(value)`.
    #22620
* Added new collaborators:
  * boneskull (https://github.com/boneskull) - Christopher Hiller
* The Technical Steering Committee has new members:
  * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski
  * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof

PR-URL: #22932
targos added a commit to nodejs/nodejs.org that referenced this pull request Sep 20, 2018
targos added a commit to nodejs/nodejs.org that referenced this pull request Sep 20, 2018
@targos targos deleted the v10.11.0-proposal branch September 20, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.