Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: rename symbols to match guidelines #22770

Closed
wants to merge 1 commit into from
Closed

crypto: rename symbols to match guidelines #22770

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Sep 9, 2018

As suggested by @addaleax in #22684, rename symbols to match the variable name.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Sep 9, 2018
@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/838/pipeline

@tniessen
Copy link
Member Author

Thanks @danbev for starting CI: https://ci.nodejs.org/job/node-test-pull-request/17127/

@tniessen
Copy link
Member Author

tniessen commented Sep 12, 2018 •
edited
Loading

CI was stopped, rebuilding everything... https://ci.nodejs.org/job/node-test-pull-request/17141/
Resuming... https://ci.nodejs.org/job/node-test-pull-request/17154/
Fourth attempt... https://ci.nodejs.org/job/node-test-pull-request/17156/

tniessen added a commit to tniessen/node that referenced this pull request Sep 12, 2018
@tniessen
crypto: rename symbols to match guidelines
79d2536 
PR-URL: nodejs#22770
Refs: nodejs#22684
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@tniessen
Copy link
Member Author

CI is yellow, GH is still not updating. Landed in 79d2536.

@tniessen tniessen closed this Sep 12, 2018
targos pushed a commit that referenced this pull request Sep 14, 2018
@tniessen @targos
crypto: rename symbols to match guidelines
b87ab0f 
PR-URL: #22770
Refs: #22684
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
@tniessen @targos
crypto: rename symbols to match guidelines
350ef49 
PR-URL: #22770
Refs: #22684
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 20, 2018
@tniessen @targos
crypto: rename symbols to match guidelines
9b58b79 
PR-URL: #22770
Refs: #22684
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @nodejs-github-bot @jasnell @addaleax @lpinca @targos @cjihrig @BridgeAR