test: refactor structure of common/index #22511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/testing |
lpinca
approved these changes
Aug 25, 2018
test/common/index.js
Outdated
| get localhostIPv4() { | ||
| if (localhostIPv4 !== null) return localhostIPv4; | ||
|
|
||
| if (exports.inFreeBSDJail) { |
refack
reviewed
Aug 25, 2018
test/common/index.js
Outdated
|
|
||
| let PIPE; |
There was a problem hiding this comment.
Suggestion, use IIFE:
const PIPE = (() => {
const localRelative = path.relative(process.cwd(), `${tmpdir.path}/`);
const pipePrefix = isWindows ? '\\\\.\\pipe\\' : localRelative;
const pipeName = `node-test.${process.pid}.sock`;
return path.join(pipePrefix, pipeName);
})()
|
+10 for readability, and style conformance. |
jasnell
added
the
author ready
jasnell
force-pushed
the
test-refactor-index
branch
from
3c7b47f
to
a38522d
Compare
addaleax
removed
the
author ready
|
@jasnell This needs a rebase, sorry :/ |
|
Ping @jasnell |
|
Haven't forgotten. I've just been moving ;-) ... will be finishing this up today. |
jasnell
force-pushed
the
test-refactor-index
branch
from
e82face
to
dca6d29
Compare
|
CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/17033/ |
BridgeAR
approved these changes
Sep 5, 2018
BridgeAR
added
the
author ready
jasnell
added a commit
that referenced
this pull request
Sep 5, 2018
PR-URL: #22511 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 286ca2c |
targos
pushed a commit
that referenced
this pull request
Sep 12, 2018
PR-URL: #22511 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 19, 2018
PR-URL: #22511 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2018
PR-URL: #22511 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further work on restructuring
common/index.js. This updates to themodule.exports = {}structure so that it's easier to see what exactly is being exported. Part of an ongoing effort to incrementally de-monolith-ize the thing.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes