meta: tweaks and cleanup #1669
Closed
meta: tweaks and cleanup #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tar version 3 performs better and is more well tested than its predecessor. npm will be using this in the near future, so there is no benefit in shipping a node-gyp that uses the slower and less reliable fstream-based tar. This drops support for node 0.x, and thus should be considered a breaking semver-major change. PR-URL: nodejs#1212 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
* dropping support for node < 4 * signal the CI not to test node < 4
If you're providing a path to a header tarball to install, you probably want it to always be re-installed. PR-URL: nodejs#1220 Fixes: nodejs#1216 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
* test: build simple addon in path with non-ascii characters * test: add test-charmap.py PR-URL: nodejs#1203 Reviewed-By: Refael Ackermann <[email protected]>
Enable linking to the platform specific installation instructions PR-URL: nodejs#1225 Reviewed-By: Refael Ackermann <[email protected]>
Lifted verbatim from https://github.com/nodejs/node/blob/master/CONTRIBUTING.md then `s/Node.js/node-gyp/`. PR-URL: nodejs#1229 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Give users reporting bugs a clearer idea of the info that will be helpful when reporting issues. PR-URL: nodejs#1228 Refs: https://github.com/nodejs/node/tree/master/.github Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: nodejs#1292 Refs: nodejs#1195 (comment) Reviewed-By: Ben Noordhuis <[email protected]>
Initial work to add z/OS support to node-gyp. PR-URL: nodejs#1276 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
GYP automatically turns variables ending in _dir, _file or _path into absolute paths but didn't check for empty strings. It interacted badly with variables inherited through the environment from npm, the `scripts-prepend-node-path=false` setting in particular because it is turned into `npm_config_script_prepend_node_path=`. Fixes: nodejs#1217 PR-URL: nodejs#1267 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
The description erroneously stated that it should point the node binary. It needs to point to the node source code. PR-URL: nodejs#1372 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Retry the download+install dance only once after encountering an EACCES. That only happens when both the devdir (usually: `$HOME/.node-gyp`) and the current working directory aren't writable. Users won't often hit that except through `sudo npm install` because npm drops privileges before executing node-gyp. Fixes: nodejs#1383 PR-URL: nodejs#1384 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Richard Lau <[email protected]>
As node-gyp rebuild doesn't seem to need xcodebuild, we don't need to be printing the error every time GYP is run. PR-URL: nodejs#1370 Fixes: nodejs#569 Refs: nodejs#1057 Refs: https://chromium-review.googlesource.com/c/492046/
PR-URL: nodejs#1323 Fixes: nodejs#1295 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
This fixes the regular expression matching in `xcode_emulation` to also handle version numbers with multiple-digit major versions which would otherwise break under use of XCode 10 Fixes: nodejs#1454 PR-URL: nodejs#1455 Reviewed-By: Ben Noordhuis <[email protected]>
Node.js on z/OS uses shared dll (libnode.so). When linking native addons, node-gyp needs to find the corresponding libnode.x during the link step. PR-URL: nodejs#1451 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#1451 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#1167 Reviewed-By: Ben Noordhuis <[email protected]>
Currently, on non-Windows platforms, it is possible to have a multi-target native module and specify building just some of the targets using `node-gyp build my_target`. On Windows, however, specifying the targets to build requires the `/t:` or `/target:` flag. Without this change you will get an `MSB1008` error because MSBuild thinks you are trying to specify multiple solutions. PR-URL: nodejs#1164 Reviewed-By: Ben Noordhuis <[email protected]>
Header files for deps are in a different location in the Node.js source tree compared to the release tarballs. PR-URL: nodejs#1055 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: nodejs#1158 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#1436 Reviewed-By: Ben Noordhuis <[email protected]>
Shrinks node-gyp's size by about 100 kB. PR-URL: nodejs#1458 Reviewed-By: Richard Lau <[email protected]>
Fixes grammar, removes extra lines and spaces, etc. Also removes a few references to `node-waf`, which was removed ~6 years ago now. Happy to add back if people still need that information. PR-URL: nodejs#1498 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- Removes "module dependencies" comments and things that, IMHO, don't add too much value. Happy to add back if helps some people when reading through `node-gyp`. - DRY up `lib/process-release.js`. - Removes a bunch of extra blank lines, as well as random spaces. PR-URL: nodejs#1508 Reviewed-By: Richard Lau <[email protected]>
- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test` PR-URL: nodejs#1497 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: João Reis <[email protected]>
This makes the parsing more robust and fixes the additional issue related to USB Device Connectivity component. Fixes: nodejs#1466 PR-URL: nodejs#1516 Reviewed-By: João Reis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This is cleaner than filtering additional strings from platform.python_version(). PR-URL: nodejs#1504 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Fixes: nodejs#1472 PR-URL: nodejs#1490 Reviewed-By: Jon Moss <[email protected]>
On Python 2, basestring is (unicode, str). On Python 3, basestring and unicode are gone, and there is only str.
nodejs#1150 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#1333 Reviewed-By: Refael Ackermann <[email protected]>
target is an undefined name in this context. nodejs#1334 Reviewed-By: Refael Ackermann <[email protected]>
Breaking change: needs Node.js version 6 or higher nodejs#1570 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#1570 Fixes: nodejs#175 Fixes: nodejs#1124 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#1534 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#1340 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#1566 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#1269 Refs: nodejs#1582 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: João Reis <[email protected]>
Try everything until Python is found. PR-URL: nodejs#1582 Reviewed-By: Rod Vagg <[email protected]>
PR-URL: nodejs#1245 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Suggest using --verbose npm switch when providing logs. Hopefully, better direct users to use backticks correctly. PR-URL: nodejs#1618 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
It isn't possible to access `tools/gyp/pylib/gyp/generator/compile_commands_json.py` using the `--format` option. This commit moves the file in a place where it can be accessed. Fixes: nodejs#1526 PR-URL: nodejs#1661 Reviewed-By: Ben Noordhuis <[email protected]> Signed-off-by: Paul Maréchal <[email protected]>
PR-URL: nodejs#1655 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: João Reis <[email protected]>
Since ARM64 build dependencies are not included in the "Desktop development with C++" workload of Visual Studio 2017, this change adds a note explaining what additional components are required to build native modules for the new Windows platform. PR-URL: nodejs#1655 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: João Reis <[email protected]>
PR-URL: nodejs#1650 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
If node-gyp configure has set up MSBuild location use it instead the one that happens to be first on the PATH. PR-URL: nodejs#1654 Fixes: nodejs#1653 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: João Reis <[email protected]>
|
@refack do you want to rebase this against master? |
|
still want to pursue this @refack? rebase and let's discuss the items, a lot of them look good to me |
This was referenced Oct 3, 2021
|
Closing, given the large number of conflicts and time that has past since this was last updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Just some cleanup and tweaks