node-gyp fails to find VS 2017 if "USB Device Connectivity" component is installed in VS 15.7 #1466
Assignees
Labels
Comments
|
/cc @refack |
|
Looking into this. |
2 tasks
Loghorn
added a commit
to Loghorn/node-gyp
that referenced
this issue
Aug 2, 2018
This makes the parsing more robust and fixes the additional issue related to USB Device Connectivity component. Fixes: nodejs#1466
joaocgreis
pushed a commit
to JaneaSystems/node-gyp
that referenced
this issue
Aug 8, 2018
This makes the parsing more robust and fixes the additional issue related to USB Device Connectivity component. Fixes: nodejs#1466
joaocgreis
pushed a commit
that referenced
this issue
Aug 8, 2018
This makes the parsing more robust and fixes the additional issue related to USB Device Connectivity component. Fixes: #1466 PR-URL: #1516 Reviewed-By: João Reis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
node-gyp configure will fail to find VS 2017 if a full installation of 15.7 is installed.
Visual Studio 15.7 added a new optional component named "USB Device Connectivity". The id of the component is
Microsoft.VisualStudio.Component.Windows10SDK.IpOverUsb. This will cause the UInt32.Parse call in the line of code linked below to throw, resulting in node-gyp using default settings.node-gyp/lib/Find-VS2017.cs
Line 235 in b5b52f7
Maybe consider a try/catch for the parse, or checking with regex that parts[0] is actually a valid number.
The text was updated successfully, but these errors were encountered: