win: improve parsing of SDK version

This makes the parsing more robust and fixes the additional issue related to USB Device Connectivity component. Fixes: nodejs#1466
Loghorn · Aug 2, 2018 · 251d2ca · 251d2ca
1 parent 6b0f4ae
commit 251d2ca
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/Find-VS2017.cs b/lib/Find-VS2017.cs
@@ -232,7 +232,9 @@ private static bool CheckInstance(ISetupInstance2 setupInstance2, ref StringBuil
                     string[] parts = id.Substring(Win10SDKPrefix.Length).Split('.');
                     if (parts.Length > 1 && parts[1] != "Desktop")
                         continue;
-                    Win10SDKVer = Math.Max(Win10SDKVer, UInt32.Parse(parts[0]));
+                    uint foundSdkVer;
+                    if (UInt32.TryParse(parts[0], out foundSdkVer))
+                        Win10SDKVer = Math.Max(Win10SDKVer, foundSdkVer);
                 } else if (id == "Microsoft.VisualStudio.Component.Windows81SDK")
                     hasWin8SDK = true;
                 else