-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.4.0-alpha.5 to master #112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* VOCDensity fix * minor logging style and service name changes/alignment * add NPM config
additional debug logging in StateHandler
removed some blank lines moved santize function our of module.exports in StateManager
nodemon will monitor select files and restart homebridge on changes
Added additional API error handling and token re-use checks
added new items to config and readme (no code changes yet): - disableAirQuality - disableCarbonDioxide - disableHumidity
Debug logging changes Added several TODOs Readme copy updates
… possible add support for 3D swing (vertical+horizontal) and made to existing controls remove swingMode characteristic from services when verticalSwing disabled in config
…wouldn't be removed when toggled off in config, copy changes, style/linting changes, additional debug logging
- adding carbonDioxideAlertThreshold - adding disableAirConditioner - config schema changes including conditional display - added VOCDENSITY_MAX const - Readme changes - set (current temperature) value to minValue when increasing minValue during setProps to remove debug warning - changed logic that sets min and max capable temps
logic for disableAirQuality and disableCO2
some minor logging changes introduced modesToExclude option (not implemented yet)
removed disableAirConditioner from being a setting, now internally calculated
added updateValue to Helper.js used Helper.updateValue in AirConditioner linting change for switch statements minor styling / logging changes
added samplePayloads to .gitignore
Commented out updateValue in AirCon.js Debug change in StateManager.js Removed duplication and added FIXME in Utils.js
benwebbbenwebb
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
dependencies
Pull requests that update a dependency file
labels
Oct 26, 2023
Closed
As discussed in #111 merging v2.4.0-alpha.5 in the master to unblock adding merging future PRs. |
This was
linked to
issues
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues:
New features:
README.md copy and style changes
package.json version bumps
linting and code style changes