Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Option to disable vertical swing #90

Closed
RB72 opened this issue Oct 12, 2022 · 9 comments · Fixed by #112
Closed

Feature Request: Option to disable vertical swing #90

RB72 opened this issue Oct 12, 2022 · 9 comments · Fixed by #112
Labels
enhancement New feature or request

Comments

@RB72
Copy link

RB72 commented Oct 12, 2022

I am using two Sensibo Air’s to control airco’s with HomeKit.
Would it be possible to add a config option (disableVerticalSwing?) to disable the vertical swing button?
Thank you in advance!

@RB72
Copy link
Author

RB72 commented Dec 25, 2022

Is it possible to implement this option?

@benwebbbenwebb benwebbbenwebb added the enhancement New feature or request label Dec 25, 2022
@benwebbbenwebb
Copy link
Collaborator

Sure @RB72, I’ll take a look

Double checking, is the goal to hide the Oscillate (vertical swing) switch/sliders when looking at the Accessories in Homebridge and Apple Home app?

@RB72
Copy link
Author

RB72 commented Dec 25, 2022

Correct.
I don’t want users to change the horizontal and vertical swing. The horizontal swing is already configurable to be disabled, but the vertical swing is not. In the Home app the AC accessoire has a button to turn on/off the (vertical) swing. I would like to disable/hide that button if possible.
Thanks in advance!
26B32289-E384-42EC-B305-B5E80146D03C

@benwebbbenwebb
Copy link
Collaborator

Hi @RB72

I've just pushed an alpha release, 2.4.0-alpha.1, that includes this enhancement.

New option added, disableVerticalSwing.

One thing I did note is that for this change to take effect in the Home app you'll unfortunately need to "reset" the Aircon accessory by using the in-built Homebridge 'Remove Single Cached Accessory' option within Homebridge Settings.

I'll take a look over the next few days to see if it's possible to change that requirement.

@RB72
Copy link
Author

RB72 commented Dec 30, 2022

Hi Ben,
Yeah, great, that is exactly what I needed, thank you 🙏 👍
Indeed it would be better if one doesn’t need to clear the cached devices, so hopefully you can find something for that too.
Kind regards,
René

@benwebbbenwebb
Copy link
Collaborator

benwebbbenwebb commented Jan 3, 2023

Hey René @RB72

Is it possible for you to share the swing / verticalSwing section(s) of your Sensibo response payload?

Examples:
"swing": [
"stopped",
"rangeFull"
]

"swing": [
"stopped",
"rangeFull",
"horizontal",
"both"
]

@RB72
Copy link
Author

RB72 commented Jan 3, 2023

Sure;

"swing":["stopped","fixedTop","fixedMiddleTop","fixedMiddle","fixedMiddleBottom","fixedBottom","rangeFull"],"horizontalSwing":["stopped","fixedLeft","fixedCenterLeft","fixedCenter","fixedCenterRight","fixedRight","fixedLeftRight","rangeCenter","rangeFull"]

@benwebbbenwebb
Copy link
Collaborator

Hi @RB72

I've spent some more time on this and haven't found a solution to 'force' a refresh back to the Home app unfortunately.

I've raised an issue / question with the core Homebridge platform asking for assistance so will see what they suggest if and when they come back.

For now the work-around of removing and re-adding the accessory will have to do when a user wants to remove a cached characteristic.

@RB72
Copy link
Author

RB72 commented Jan 29, 2023

Yes, that is not a problem. Perhaps a little footnote in user interface or something like that to get the users attention when you change this setting you have to remove the single cached device. This perhaps prevents some support questions 😁

@benwebbbenwebb benwebbbenwebb linked a pull request Oct 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants