Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password with an & #66

Closed
mipaso opened this issue Jul 23, 2021 · 4 comments · Fixed by #112
Closed

Password with an & #66

mipaso opened this issue Jul 23, 2021 · 4 comments · Fixed by #112
Assignees
@benwebbbenwebb
Labels
bug Something isn't working

Comments

@mipaso
Copy link

mipaso commented Jul 23, 2021

Hi there

fyi if the character & is used in a password, then password check fails with error 401.

You may want to insure and sanityse variable entries when parsing the config file.
benwebbbenwebb added a commit that referenced this issue Dec 30, 2022
@benwebbbenwebb
Fixed issue #66 &s in passwords
0cd9d6d 
Added additional API error handling and token re-use checks
@benwebbbenwebb
Copy link
Collaborator

Hi @mipaso

I've just pushed an alpha release, 2.4.0-alpha.1, that should fix this issue

@mipaso
Copy link
Author

mipaso commented Apr 18, 2023

hi @benwebbbenwebb

sorry I overlook your answer !

it works perfectly.

Thanks

@mipaso
Copy link
Author

mipaso commented Apr 18, 2023

corrected

@benwebbbenwebb benwebbbenwebb added the bug Something isn't working label Apr 25, 2023
@benwebbbenwebb benwebbbenwebb self-assigned this Apr 25, 2023
@benwebbbenwebb
Copy link
Collaborator

Thanks for the feedback @mipaso

I'll make sure the fix is included in the next main release

@benwebbbenwebb benwebbbenwebb mentioned this issue Oct 26, 2023
Merged
@benwebbbenwebb benwebbbenwebb linked a pull request Oct 26, 2023 that will close this issue
v2.4.0-alpha.5 to master #112
Merged
benwebbbenwebb added a commit that referenced this issue Oct 26, 2023
@benwebbbenwebb
Move v2.4.0-alpha.5 from development branch to master (#112)
1425c12 
Fixes issues:
- #63 - undefined fanSpeed
- #66 - &s in passwords
- #89 - vertical swing state

New features:
- AirQuality (VOC) + disable
- CO2 + disable
- Disable Humidity
- Swing changes, including disable VerticalSwing
- ModesToExclude

Other changes:
- README.md copy and style changes
- package.json version bumps
- Linting and code style changes, logging changes
- API error handling, token re-use
- New logic for max and mins to reduce warnings thrown to HB logs
- Started extracting common functionality out to Utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benwebbbenwebb benwebbbenwebb

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.4.0-alpha.5 to master nitaybz/homebridge-sensibo-ac
2 participants
@benwebbbenwebb @mipaso