Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish completely removing web folder #9304

Closed
timotheecour opened this issue Oct 11, 2018 · 4 comments
Closed

finish completely removing web folder #9304

timotheecour opened this issue Oct 11, 2018 · 4 comments

Comments

@timotheecour
Copy link
Member

timotheecour commented Oct 11, 2018 •
edited
Loading

/cc @narimiran
after #9290 and #9233

#9277 (comment)
@kaushalmodi
Copy link
Contributor

But looks like nimblepkglist.nim needs to be kept for now. It seems like the cleanup in done there (until it's deemed that nimblepkglist.nim is no longer needed).

#9277 (comment)

@timotheecour
Copy link
Member Author

i thought it was still there as an accident, feel free to close if it's intended to be there

@timotheecour
Copy link
Member Author

timotheecour commented Oct 11, 2018 •
edited
Loading

@Araq suggested:

From IRC (bridge bot) @FromIRC 03:57
@narimiran: move nimblepkglist.nim to tools/

narimiran added a commit to narimiran/Nim that referenced this issue Oct 11, 2018
@narimiran
complete removal of web folder, fixes nim-lang#9304
9a6b108
@narimiran
Copy link
Member

PR submitted, let's wait for the tests.

@Araq Araq closed this as completed in c492a7f Oct 12, 2018
krux02 pushed a commit to krux02/Nim that referenced this issue Oct 15, 2018
@narimiran @krux02
complete removal of web folder, fixes nim-lang#9304 (nim-lang#9310)
249b8c3 
* complete removal of web folder, fixes nim-lang#9304

* remove `buildJS`
narimiran added a commit to narimiran/Nim that referenced this issue Oct 31, 2018
@narimiran
complete removal of web folder, fixes nim-lang#9304 (nim-lang#9310)
40a6faf 
* complete removal of web folder, fixes nim-lang#9304

* remove `buildJS`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andreaferretti @timotheecour @kaushalmodi @narimiran