Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completely remove web folder #9277

Closed
wants to merge 2 commits into from
Closed

Conversation

narimiran
Copy link
Member

Finish what was started in #9233.

@kaushalmodi kaushalmodi mentioned this pull request Oct 10, 2018
@kaushalmodi
Copy link
Contributor

fails because of:

�[0K$ ./koch docs
bin/nim js -d:release --out:web/upload/nimblepkglist.js web/nimblepkglist.nim
Error: unhandled exception: No such file or directory [OSError]

@Araq looks like web/ dir and nimblepkglist.nim are used here.

@kaushalmodi
Copy link
Contributor

If nimblepkglist.js is not used anywhere then we need to remove these too:

@narimiran
Copy link
Member Author

Thanks @kaushalmodi for the details. Now I have deleted those too, let's wait and see what the tests say.

@Araq
Copy link
Member

Araq commented Oct 11, 2018

Sorry, let's keep nimblepkglist.nim for the time being, merging #9290 instead.

@Araq Araq closed this Oct 11, 2018
@narimiran narimiran deleted the remove-web branch October 14, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants