complete removal of web folder, fixes #9304 #9310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
reviewed
Oct 11, 2018
tools/nimweb.nim
Outdated
| @@ -446,7 +446,7 @@ proc buildNewsRss(c: var TConfigData, destPath: string) = | |||
| generateRss(destFilename, parseNewsTitles(srcFilename)) | |||
|
|
|||
| proc buildJS(c: TConfigData) = | |||
| exec(findNim(c) & " js -d:release --out:$1 web/nimblepkglist.nim" % | |||
| exec(findNim(c) & " js -d:release --out:$1 tools/nimblepkglist.nim" % | |||
There was a problem hiding this comment.
You can just remove this AFAIK
There was a problem hiding this comment.
Ok, I removed that function.
|
Regarding failing tests: the first time job1 failed and job2 passed, the second time it was vice versa. I didn't see any failing test neither time. |
krux02
pushed a commit
to krux02/Nim
that referenced
this pull request
Oct 15, 2018
* complete removal of web folder, fixes nim-lang#9304 * remove `buildJS`
narimiran
added a commit
to narimiran/Nim
that referenced
this pull request
Oct 31, 2018
* complete removal of web folder, fixes nim-lang#9304 * remove `buildJS`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.