Rich text editor | Fix nested list highlighting #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sai krishnan Perumal <[email protected]>
Signed-off-by: Sai krishnan Perumal <[email protected]>
Signed-off-by: Sai krishnan Perumal <[email protected]>
Signed-off-by: Sai krishnan Perumal <[email protected]>
vikisekarNI
reviewed
Aug 29, 2023
vikisekarNI
approved these changes
Aug 29, 2023
Signed-off-by: Sai krishnan Perumal <[email protected]>
vikisekarNI
reviewed
Aug 29, 2023
Signed-off-by: Sai krishnan Perumal <[email protected]>
m-akinc
approved these changes
Aug 29, 2023
Signed-off-by: Sai krishnan Perumal <[email protected]>
jattasNI
approved these changes
Aug 30, 2023
change/@ni-nimble-components-184413cc-afcf-4db1-b373-1bdb1a98f015.json
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/rich-text-editor/tests/rich-text-editor.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Aug 30, 2023
Signed-off-by: Sai krishnan Perumal <[email protected]>
Signed-off-by: Sai krishnan Perumal <[email protected]>
1 task
rajsite
pushed a commit
that referenced
this pull request
Sep 7, 2023
…l behavior (#1481) # Pull Request ## 🤨 Rationale - Resolves #1473, where different type of list element is possible to be added in same level. It can be reproduced using the steps from #1462 (comment) ## 👩💻 Implementation - Added unit and ui test for the possibility of having different type of list element in same level ## 🧪 Testing - Added unit and ui testing ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Signed-off-by: Sai krishnan Perumal <[email protected]> Signed-off-by: Sai krishnan Perumal <[email protected]> Co-authored-by: m-akinc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Fixes #1434
👩💻 Implementation
findParentNodemethod from tiptap/core to find the current node type🧪 Testing
✅ Checklist