Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich Text Editor | Able to have different type of list element in same level #1473

Closed
saikrishnan-ni opened this issue Aug 31, 2023 · 0 comments · Fixed by #1481
Closed

Rich Text Editor | Able to have different type of list element in same level #1473

saikrishnan-ni opened this issue Aug 31, 2023 · 0 comments · Fixed by #1481
Labels
tech debt

Comments

@saikrishnan-ni
Copy link
Contributor

🧹 Tech Debt

We're able to have different type of list item on same level for sublist items in nimble-rich-text-editor which uses tiptap editor. This behavior is from of tiptap editor which can be reproduced from the steps followed in this #1462 (comment). We should either find a way to prevent mixing sublist types or have tests for it.
@saikrishnan-ni saikrishnan-ni added tech debt triage New issue that needs to be reviewed labels Aug 31, 2023
@saikrishnan-ni saikrishnan-ni mentioned this issue Aug 31, 2023
Merged
1 task
@saikrishnan-ni saikrishnan-ni linked a pull request Sep 4, 2023 that will close this issue
Rich text editor | Add tests for different list elements in same level behavior #1481
Merged
1 task
@saikrishnan-ni saikrishnan-ni mentioned this issue Sep 4, 2023
Merged
1 task
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Sep 5, 2023
@m-akinc m-akinc moved this to In progress in Nimble Design System Priorities Sep 5, 2023
rajsite pushed a commit that referenced this issue Sep 7, 2023
@saikrishnan-ni @m-akinc
Rich text editor | Add tests for different list elements in same leve…
aa91800 
…l behavior (#1481)

# Pull Request

## 🤨 Rationale

- Resolves #1473, where different
type of list element is possible to be added in same level.
It can be reproduced using the steps from
#1462 (comment)

## 👩‍💻 Implementation

- Added unit and ui test for the possibility of having different type of
list element in same level

## 🧪 Testing

- Added unit and ui testing

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Signed-off-by: Sai krishnan Perumal <[email protected]>
Signed-off-by: Sai krishnan Perumal <[email protected]>
Co-authored-by: m-akinc <[email protected]>
@m-akinc m-akinc moved this from In progress to Done in Nimble Design System Priorities Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
Nimble Design System Priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rich text editor | Add tests for different list elements in same level behavior ni/nimble
2 participants
@m-akinc @saikrishnan-ni