Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all upload/download-artifact uses to v4 #1068

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

maxxboehme
Copy link
Collaborator

@maxxboehme maxxboehme commented Jun 27, 2024

What does this Pull Request accomplish?

fixes #1066

Use the latest version of download-artifacts away from deprecated versions.

Why should this Pull Request be merged?

The older versions will be deprecated and latest version has possible speed improvements.

What testing has been done?

  • All downloads appear to be to a unique directory. If not this a new argument would be needed.
  • All uploads updated to be unique since with v4 no merging is allowed.
  • PR build and testing

@maxxboehme maxxboehme changed the title Update all download-artifact uses to v4 Update all upload/download-artifact uses to v4 Jun 27, 2024
@maxxboehme maxxboehme marked this pull request as ready for review June 27, 2024 23:07
@maxxboehme maxxboehme merged commit 1cd0fb1 into ni:main Jun 28, 2024
10 of 11 checks passed
@maxxboehme maxxboehme deleted the update_download-artifact_version_to_v4 branch June 28, 2024 20:23
jonathanou pushed a commit that referenced this pull request Oct 12, 2024
* Update all download-artifact uses to v4

* Update upload-artifact to v4

---------

Co-authored-by: Maxx Boehme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upload/download-artifact v2 will be deprecated on June 30, 2024
2 participants