Update all upload/download-artifact uses to v4 (#1068)

* Update all download-artifact uses to v4 * Update upload-artifact to v4 --------- Co-authored-by: Maxx Boehme <[email protected]>
ni · Jun 28, 2024 · 1cd0fb1 · 1cd0fb1
1 parent 0e62da1
commit 1cd0fb1
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 28 deletions.
diff --git a/.github/workflows/build_cmake.yml b/.github/workflows/build_cmake.yml
@@ -124,7 +124,7 @@ jobs:
         ThirdPartyNotices.txt
 
     - name: Upload Linux Server Binaries Artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Linux') }}
       with:
         name: ni-grpc-device-server-linux-glibc${{ matrix.config.glibc_version }}-x64
@@ -148,36 +148,28 @@ jobs:
         ThirdPartyNotices.txt
 
     - name: Upload Linux Test Binaries Artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       if: ${{ runner.os == 'Linux' }}
       with:
         name: ni-grpc-device-tests-linux-glibc${{ matrix.config.glibc_version }}-x64
         path: ni-grpc-device-tests-linux-glibc${{ matrix.config.glibc_version }}-x64.tar.gz
         retention-days: 5
 
-    - name: Upload Windows Server Information Artifact
-      uses: actions/upload-artifact@v2
+    - name: Upload Windows Server Artifact
+      uses: actions/upload-artifact@v4
       if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Windows') }}
       with:
         name: ni-grpc-device-server-windows-x64
         path: |
           LICENSE
           ThirdPartyNotices.txt
-        retention-days: 5
-
-    - name: Upload Windows Server Binaries Artifact
-      uses: actions/upload-artifact@v2
-      if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Windows') }}
-      with:
-        name: ni-grpc-device-server-windows-x64
-        path: |
           build/RelWithDebInfo/ni_grpc_device_server.exe
           build/RelWithDebInfo/server_config.json
           build/RelWithDebInfo/server_capabilities.json
         retention-days: 5
 
     - name: Upload Windows Test Binaries Artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       if: ${{ runner.os == 'Windows' }}
       with:
         name: ni-grpc-device-tests-windows-x64
@@ -198,10 +190,10 @@ jobs:
         retention-days: 5
 
     - name: Upload Windows Server Debug Symbols Artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Windows') }}
       with:
         name: ni-grpc-device-server-windows-x64-debug-symbols
         path: |
           build/RelWithDebInfo/ni_grpc_device_server.pdb
-        retention-days: 5
+        retention-days: 5
diff --git a/.github/workflows/build_nilrt.yml b/.github/workflows/build_nilrt.yml
@@ -140,7 +140,7 @@ jobs:
         ThirdPartyNotices.txt
 
     - name: Upload Server Artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       if: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases') }}
       with:
         name: ni-grpc-device-server-ni-linux-rt-x64
@@ -164,7 +164,7 @@ jobs:
         ThirdPartyNotices.txt
 
     - name: Upload Tests Artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       if: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases') }}
       with:
         name: ni-grpc-device-tests-ni-linux-rt-x64

diff --git a/.github/workflows/create_client_artifacts.yml b/.github/workflows/create_client_artifacts.yml
@@ -47,15 +47,15 @@ jobs:
         tar -cvzf ni-grpc-device-client.tar.gz -C ${{ runner.temp }}/staging/ .
 
     - name: Upload Linux Client Files Artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Linux') }}
       with:
         name: ni-grpc-device-client-Linux
         path: ni-grpc-device-client.tar.gz
         retention-days: 5
 
     - name: Upload Windows Client Files Artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Windows') }}
       with:
         name: ni-grpc-device-client
@@ -64,7 +64,7 @@ jobs:
         retention-days: 5
 
     - name: Upload Windows Restricted Client Files Artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Windows') }}
       with:
         name: ni-grpc-device-client-restricted

diff --git a/.github/workflows/create_release.yml b/.github/workflows/create_release.yml
@@ -16,7 +16,7 @@ jobs:
       with:
         fetch-depth: 0
 
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       with:
         name: ni-grpc-device-client
         path: downloads/ni-grpc-device-client
@@ -26,22 +26,22 @@ jobs:
         files: downloads/ni-grpc-device-client
         dest: downloads/artifacts/ni-grpc-device-client.zip
 
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       with:
         name: ni-grpc-device-client-Linux
         path: downloads/artifacts
 
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       with:
         name: ni-grpc-device-server-linux-glibc2_31-x64
         path: downloads/artifacts
 
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       with:
         name: ni-grpc-device-server-ni-linux-rt-x64
         path: downloads/artifacts
 
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       with:
         name: ni-grpc-device-server-windows-x64
         path: downloads/ni-grpc-device-server-windows-x64
@@ -51,7 +51,7 @@ jobs:
         files: downloads/ni-grpc-device-server-windows-x64
         dest: downloads/artifacts/ni-grpc-device-server-windows-x64.zip
 
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       with:
         name: ni-grpc-device-server-windows-x64-debug-symbols
         path: downloads/artifacts

diff --git a/.github/workflows/run_ubuntu_system_tests.yml b/.github/workflows/run_ubuntu_system_tests.yml
@@ -15,7 +15,7 @@ jobs:
 
     steps:
     - name: Download Tests Artifact
-      uses: actions/download-artifact@v2
+      uses: actions/download-artifact@v4
       with:
         name: ni-grpc-device-tests-linux-glibc2_31-x64
 

diff --git a/.github/workflows/run_win_system_tests.yml b/.github/workflows/run_win_system_tests.yml
@@ -15,7 +15,7 @@ jobs:
 
     steps:
     - name: Download Tests Artifact
-      uses: actions/download-artifact@v2
+      uses: actions/download-artifact@v4
       with:
         name: ni-grpc-device-tests-windows-x64