Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all upload/download-artifact uses to v4 #1068

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Update all upload/download-artifact uses to v4 #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d3750c
Update all download-artifact uses to v4
Jun 27, 2024
61447af
Update upload-artifact to v4
Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions .github/workflows/build_cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
ThirdPartyNotices.txt

- name: Upload Linux Server Binaries Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Linux') }}
with:
name: ni-grpc-device-server-linux-glibc${{ matrix.config.glibc_version }}-x64
Expand All @@ -148,36 +148,28 @@ jobs:
ThirdPartyNotices.txt

- name: Upload Linux Test Binaries Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ runner.os == 'Linux' }}
with:
name: ni-grpc-device-tests-linux-glibc${{ matrix.config.glibc_version }}-x64
path: ni-grpc-device-tests-linux-glibc${{ matrix.config.glibc_version }}-x64.tar.gz
retention-days: 5

- name: Upload Windows Server Information Artifact
uses: actions/upload-artifact@v2
- name: Upload Windows Server Artifact
uses: actions/upload-artifact@v4
if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Windows') }}
with:
name: ni-grpc-device-server-windows-x64
path: |
LICENSE
ThirdPartyNotices.txt
retention-days: 5

- name: Upload Windows Server Binaries Artifact
uses: actions/upload-artifact@v2
if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Windows') }}
with:
name: ni-grpc-device-server-windows-x64
path: |
build/RelWithDebInfo/ni_grpc_device_server.exe
build/RelWithDebInfo/server_config.json
build/RelWithDebInfo/server_capabilities.json
retention-days: 5

- name: Upload Windows Test Binaries Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ runner.os == 'Windows' }}
with:
name: ni-grpc-device-tests-windows-x64
Expand All @@ -198,10 +190,10 @@ jobs:
retention-days: 5

- name: Upload Windows Server Debug Symbols Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Windows') }}
with:
name: ni-grpc-device-server-windows-x64-debug-symbols
path: |
build/RelWithDebInfo/ni_grpc_device_server.pdb
retention-days: 5
retention-days: 5
4 changes: 2 additions & 2 deletions .github/workflows/build_nilrt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ jobs:
ThirdPartyNotices.txt

- name: Upload Server Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases') }}
with:
name: ni-grpc-device-server-ni-linux-rt-x64
Expand All @@ -164,7 +164,7 @@ jobs:
ThirdPartyNotices.txt

- name: Upload Tests Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases') }}
with:
name: ni-grpc-device-tests-ni-linux-rt-x64
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/create_client_artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ jobs:
tar -cvzf ni-grpc-device-client.tar.gz -C ${{ runner.temp }}/staging/ .

- name: Upload Linux Client Files Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Linux') }}
with:
name: ni-grpc-device-client-Linux
path: ni-grpc-device-client.tar.gz
retention-days: 5

- name: Upload Windows Client Files Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Windows') }}
with:
name: ni-grpc-device-client
Expand All @@ -64,7 +64,7 @@ jobs:
retention-days: 5

- name: Upload Windows Restricted Client Files Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases')) && (runner.os == 'Windows') }}
with:
name: ni-grpc-device-client-restricted
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/create_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
with:
fetch-depth: 0

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ni-grpc-device-client
path: downloads/ni-grpc-device-client
Expand All @@ -26,22 +26,22 @@ jobs:
files: downloads/ni-grpc-device-client
dest: downloads/artifacts/ni-grpc-device-client.zip

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ni-grpc-device-client-Linux
path: downloads/artifacts

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ni-grpc-device-server-linux-glibc2_31-x64
path: downloads/artifacts

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ni-grpc-device-server-ni-linux-rt-x64
path: downloads/artifacts

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ni-grpc-device-server-windows-x64
path: downloads/ni-grpc-device-server-windows-x64
Expand All @@ -51,7 +51,7 @@ jobs:
files: downloads/ni-grpc-device-server-windows-x64
dest: downloads/artifacts/ni-grpc-device-server-windows-x64.zip

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ni-grpc-device-server-windows-x64-debug-symbols
path: downloads/artifacts
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run_ubuntu_system_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

steps:
- name: Download Tests Artifact
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: ni-grpc-device-tests-linux-glibc2_31-x64

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run_win_system_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

steps:
- name: Download Tests Artifact
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: ni-grpc-device-tests-windows-x64

Expand Down
Loading