Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: migrate to Nx workspace #136

Merged
merged 24 commits into from
Oct 25, 2022
Merged

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Oct 24, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Our CI workflow is broken and we are not publishing a partially Ivy-compiled bundle.

Issue Number: N/A

What is the new behavior?

We use Nrwl's Nx Cloud DTE workflow and we can publish a partially Ivy-compiled bundle.

Does this PR introduce a breaking change?

[x] Yes
[ ] No
  • Require Angular 14.0
  • Require RxJS 7.4

Other information

Merging from https://github.com/ngworker/lumberjack-next.

Closes #101, closes #84, closes #98

@LayZeeDK LayZeeDK requested a review from NachoVazquez October 24, 2022 21:27
Copy link
Contributor

@NachoVazquez NachoVazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for the effort so far it is looking great.

I left a couple of minor comments but the rest is starting to fit.

.eslintrc.json Show resolved Hide resolved
packages/ngworker/lumberjack/project.json Outdated Show resolved Hide resolved
@LayZeeDK LayZeeDK marked this pull request as ready for review October 25, 2022 12:48
@LayZeeDK LayZeeDK requested a review from NachoVazquez October 25, 2022 12:48
NachoVazquez
NachoVazquez previously approved these changes Oct 25, 2022
Copy link
Contributor

@NachoVazquez NachoVazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@LayZeeDK LayZeeDK force-pushed the chore/migrate-to-nx-workspace branch from aa1cc03 to 2e9335d Compare October 25, 2022 13:58
@LayZeeDK LayZeeDK force-pushed the chore/migrate-to-nx-workspace branch from 2e9335d to f43ebf1 Compare October 25, 2022 14:08
@LayZeeDK
Copy link
Member Author

Thank you for the review, @NachoVazquez

I have shaved off 1 minute of CI time by including the e2e tests in parallel DTE agent tasks.

I also addressed the following issues.

  • The custom build target was missing production and development configurations
  • The build-package target wasn't cached by Nx
  • The log payload wasn't covered by end-to-end tests

@LayZeeDK LayZeeDK requested a review from NachoVazquez October 25, 2022 14:12
@LayZeeDK
Copy link
Member Author

Hmm, the lint and test coverage report tasks aren't cached between the DTE jobs and the SonarCloud job.

@NachoVazquez
Copy link
Contributor

Thank you for the review, @NachoVazquez

I have shaved off 1 minute of CI time by including the e2e tests in parallel DTE agent tasks.

I also addressed the following issues.

  • The custom build target was missing production and development configurations
  • The build-package target wasn't cached by Nx
  • The log payload wasn't covered by end-to-end tests

Amazing!!! Thank you!

@NachoVazquez
Copy link
Contributor

Hmm, the lint and test coverage report tasks aren't cached between the DTE jobs and the SonarCloud job.

Oh, nice observation. 🤔

@LayZeeDK
Copy link
Member Author

Seems like the Nx agents aren't picking up the NX_CLOUD_ACCESS_TOKEN GitHub secret. We probably need to pass them to the reusable workflows.

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.0% 98.0% Coverage
0.0% 0.0% Duplication

@LayZeeDK
Copy link
Member Author

Success! 🙌

Copy link
Contributor

@NachoVazquez NachoVazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did it!!!!

@LayZeeDK LayZeeDK merged commit 00aba83 into main Oct 25, 2022
@LayZeeDK LayZeeDK deleted the chore/migrate-to-nx-workspace branch October 25, 2022 21:44
This was referenced Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants