-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: migrate to Nx workspace #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Thanks for the effort so far it is looking great.
I left a couple of minor comments but the rest is starting to fit.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c4aae29. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 8 targets
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
aa1cc03
to
2e9335d
Compare
2e9335d
to
f43ebf1
Compare
Thank you for the review, @NachoVazquez ❤ I have shaved off 1 minute of CI time by including the e2e tests in parallel DTE agent tasks. I also addressed the following issues.
|
…d tasks for the SonarCloud job
Hmm, the lint and test coverage report tasks aren't cached between the DTE jobs and the SonarCloud job. |
Amazing!!! Thank you! |
Oh, nice observation. 🤔 |
Seems like the Nx agents aren't picking up the |
…se cached tasks for the SonarCloud job" This reverts commit 8f72844.
Kudos, SonarCloud Quality Gate passed! |
Success! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did it!!!!
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Our CI workflow is broken and we are not publishing a partially Ivy-compiled bundle.
Issue Number: N/A
What is the new behavior?
We use Nrwl's Nx Cloud DTE workflow and we can publish a partially Ivy-compiled bundle.
Does this PR introduce a breaking change?
Other information
Merging from https://github.com/ngworker/lumberjack-next.
Closes #101, closes #84, closes #98