Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add lumberjack-ivy CI workflow #84

Closed
wants to merge 19 commits into from
Closed

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Apr 18, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Lumberjack is a View Engine-compiled package.

Issue Number: N/A

What is the new behavior?

A separate Lumberjack bundle with partial Ivy compilation is created. This enables faster compilation time for end-users but requires Angular CLI >=11.1. Technically it's fully Ivy-compiled because Lumberjack doesn't contain components.

This package could be published in parallel to @ngworker/lumberjack using a name such as @ngworker/lumberjack-ivy or @ngworker/lumberjack-angular-linker.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@LayZeeDK
Copy link
Member Author

Waiting for ngworker/angular-versions-action#22.

@NachoVazquez
Copy link
Contributor

This is very exciting.

@NachoVazquez
Copy link
Contributor

That version should not be failing. Is that a regression?

@LayZeeDK
Copy link
Member Author

That version should not be failing. Is that a regression?

I updated the dependencies and removed @angular-devkit/build-ng-packagr. We then get errors because of ngworker/angular-versions-action#22.

@LayZeeDK
Copy link
Member Author

We might want to look into the schematics e2e setup to make sure it's reusing the package build artifact and not re-building the schematics sub-package for different versions of Angular.

@LayZeeDK LayZeeDK force-pushed the ci/partial-ivy-compilation branch from eef6dd7 to b16a0f5 Compare April 26, 2021 22:27
@LayZeeDK LayZeeDK force-pushed the ci/partial-ivy-compilation branch from 90ec1d9 to e6286ba Compare April 26, 2021 23:35
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LayZeeDK LayZeeDK mentioned this pull request Oct 25, 2022
3 tasks
@LayZeeDK LayZeeDK closed this in 00aba83 Oct 25, 2022
@LayZeeDK LayZeeDK deleted the ci/partial-ivy-compilation branch October 25, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants