-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update packages and replace builder #98
Conversation
Solution: Downgrade Jest to 26.x and the Jest builder to 11.x when testing older versions of Angular with Node.js 10.x. |
Looking at angular-cli-diff, we should also change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See PR comments.
I had to explicitly upgrade because I was having other problems with version 26 after the upgrade. However, do we need to run our test in Node 10?? Can not we just perform the build using the different versions of Node but everything else (dev-related) could be done with the latest Node?? |
9611e31
to
663efd7
Compare
74236f6
to
b47842d
Compare
Kudos, SonarCloud Quality Gate passed! |
We must be able to test using Node.js 10.x with certain versions of Angular. That's what some our consumers will be using since Angular supports this version. |
b47842d
to
e097f96
Compare
@all-contributors please add @patelvimal for code |
I've put up a pull request to add @patelvimal! 🎉 |
5dcb625
to
ad50b5f
Compare
ad50b5f
to
ceeb434
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The lumberjack repo was using Angular version 11 and the old ngpackgr builder
@angular-devkit/build-ng-packagr:build
.Issue Number: N/A
What is the new behavior?
The Lumberjack repo is using the latest version of Angular (12.2.x) and the new ngpackgr builder
@angular-devkit/build-angular:ng-packagr
Does this PR introduce a breaking change?
Other information
This PR depends on ngworker/angular-versions-action#35 and ngworker/angular-versions-action#36