Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update packages and replace builder #98

Closed
wants to merge 34 commits into from

Conversation

NachoVazquez
Copy link
Contributor

@NachoVazquez NachoVazquez commented Aug 21, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The lumberjack repo was using Angular version 11 and the old ngpackgr builder @angular-devkit/build-ng-packagr:build.

Issue Number: N/A

What is the new behavior?

The Lumberjack repo is using the latest version of Angular (12.2.x) and the new ngpackgr builder @angular-devkit/build-angular:ng-packagr

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR depends on ngworker/angular-versions-action#35 and ngworker/angular-versions-action#36

@LayZeeDK
Copy link
Member

error @angular-builders/[email protected]: The engine "node" is incompatible with this module. Expected version ">=12.14.1". Got "10.24.1"

Solution: Downgrade Jest to 26.x and the Jest builder to 11.x when testing older versions of Angular with Node.js 10.x.

@LayZeeDK
Copy link
Member

LayZeeDK commented Aug 21, 2021

Looking at angular-cli-diff, we should also change compilerOptions.target from "es2015" to "es2017" in tsconfig.json.

Copy link
Member

@LayZeeDK LayZeeDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR comments.

@NachoVazquez
Copy link
Contributor Author

error @angular-builders/[email protected]: The engine "node" is incompatible with this module. Expected version ">=12.14.1". Got "10.24.1"

Solution: Downgrade Jest to 26.x and the Jest builder to 11.x when testing older versions of Angular with Node.js 10.x.

I had to explicitly upgrade because I was having other problems with version 26 after the upgrade.

However, do we need to run our test in Node 10?? Can not we just perform the build using the different versions of Node but everything else (dev-related) could be done with the latest Node??

@NachoVazquez NachoVazquez force-pushed the chore/update-angular-and-remove-builders branch from 9611e31 to 663efd7 Compare August 22, 2021 16:44
@NachoVazquez NachoVazquez requested a review from LayZeeDK August 22, 2021 20:14
@NachoVazquez NachoVazquez force-pushed the chore/update-angular-and-remove-builders branch 6 times, most recently from 74236f6 to b47842d Compare August 24, 2021 21:01
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@LayZeeDK
Copy link
Member

@NachoVazquez

However, do we need to run our test in Node 10?? Can not we just perform the build using the different versions of Node but everything else (dev-related) could be done with the latest Node??

We must be able to test using Node.js 10.x with certain versions of Angular. That's what some our consumers will be using since Angular supports this version.

@NachoVazquez NachoVazquez force-pushed the chore/update-angular-and-remove-builders branch from b47842d to e097f96 Compare March 12, 2022 21:02
@NachoVazquez
Copy link
Contributor Author

@all-contributors please add @patelvimal for code

@allcontributors
Copy link
Contributor

@NachoVazquez

I've put up a pull request to add @patelvimal! 🎉

@NachoVazquez NachoVazquez linked an issue Mar 12, 2022 that may be closed by this pull request
4 tasks
@NachoVazquez NachoVazquez force-pushed the chore/update-angular-and-remove-builders branch 14 times, most recently from 5dcb625 to ad50b5f Compare June 1, 2022 03:02
@NachoVazquez NachoVazquez force-pushed the chore/update-angular-and-remove-builders branch from ad50b5f to ceeb434 Compare June 1, 2022 03:18
@LayZeeDK LayZeeDK mentioned this pull request Oct 25, 2022
3 tasks
@LayZeeDK LayZeeDK closed this in 00aba83 Oct 25, 2022
@LayZeeDK LayZeeDK deleted the chore/update-angular-and-remove-builders branch October 25, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

chore: update to Angular 13
3 participants