Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log errors for not implemented grpc metrics #6125

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Aug 2, 2024

Proposed changes

This PR introduces a temp fix for gRPC latency metrics errors issue.

Error log messages are not emitted, instead a log message in a debug mode:

example request:

10.244.0.1 - - [02/Aug/2024:10:32:32 +0000] "POST /helloworld.Greeter/SayHello HTTP/2.0" 200 13 "-" "grpcurl/dev-build (no version set) grpc-go/1.61.0" "-"

log message in a debug mode (-v=3)

I20240802 10:32:32.615314       1 latency.go:191] latency metrics: {- 10.244.0.21:50051 200 0.032}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
@jjngx jjngx requested a review from a team as a code owner August 2, 2024 10:54
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Aug 2, 2024
@jjngx jjngx linked an issue Aug 2, 2024 that may be closed by this pull request
@jjngx jjngx added the change Pull requests that introduce a change label Aug 2, 2024
@github-actions github-actions bot removed the change Pull requests that introduce a change label Aug 2, 2024
@jjngx jjngx merged commit 1845a13 into main Aug 6, 2024
77 checks passed
@jjngx jjngx deleted the fix/latency-metrics-grpc branch August 6, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug go Pull requests that update Go code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

latency metrics are logging error re missing labels when used with grpc
3 participants