Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log errors for not implemented grpc metrics #6125

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Don't log errors for not implemented grpc metrics #6125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
352c1ef
Don't log errors for not implemented grpc metrics
jjngx Aug 2, 2024
20af342
Merge branch 'main' into fix/latency-metrics-grpc
jjngx Aug 2, 2024
a08d4d6
Merge branch 'main' into fix/latency-metrics-grpc
jjngx Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/metrics/collectors/latency.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,17 @@ func (l *LatencyMetricsCollector) RecordLatency(syslogMsg string) {
glog.V(3).Infof("could not parse syslog message: %v", err)
return
}

// Upstream for gRPC service is not implemented yet.
// This is a temp solution to avoid spamming error logs.
// Ref:
// https://github.com/nginxinc/kubernetes-ingress/issues/5010
// https://github.com/nginxinc/kubernetes-ingress/issues/6124
if lm.Upstream == "-" {
glog.V(3).Infof("latency metrics for gRPC upstreams: %v", lm)
return
}

labelValues, err := l.createLatencyLabelValues(lm)
if err != nil {
glog.Errorf("cannot record latency for upstream %s and server %s: %v", lm.Upstream, lm.Server, err)
Expand Down