Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log errors for not implemented grpc metrics (#6125) #6150

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Aug 7, 2024

Proposed changes

Cherry-pick bug fix.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner August 7, 2024 11:24
@github-actions github-actions bot added the go Pull requests that update Go code label Aug 7, 2024
@jjngx jjngx merged commit 5209b0b into release-3.6 Aug 7, 2024
66 checks passed
@jjngx jjngx deleted the cherry-pick-bug-fix branch August 7, 2024 12:18
@pdabelf5 pdabelf5 added the bug An issue reporting a potential bug label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants