Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.4.0 #4794

Merged
merged 14 commits into from
Dec 19, 2023
Merged

Release 3.4.0 #4794

merged 14 commits into from
Dec 19, 2023

Conversation

nginx-bot
Copy link
Contributor

This automated PR updates the docs for 3.4.0 release.

@nginx-bot nginx-bot requested review from a team as code owners December 13, 2023 14:43
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Dec 13, 2023
haywoodsh
haywoodsh reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@haywoodsh haywoodsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version update missing
https://github.com/nginxinc/kubernetes-ingress/blob/docs/release-3.4.0/examples/custom-resources/service-insight/README.md?plain=1#L35
https://github.com/nginxinc/kubernetes-ingress/blob/docs/release-3.4.0/examples/custom-resources/service-insight/README.md?plain=1#L324

@github-actions github-actions bot added the tests Pull requests that update tests label Dec 13, 2023
@github-actions github-actions bot removed the tests Pull requests that update tests label Dec 13, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d95575) 52.01% compared to head (9bc72ee) 52.01%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-3.4    #4794   +/-   ##
============================================
  Coverage        52.01%   52.01%           
============================================
  Files               60       60           
  Lines            17313    17313           
============================================
  Hits              9005     9005           
  Misses            7995     7995           
  Partials           313      313

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaun-nx
Copy link
Contributor

version update missing https://github.com/nginxinc/kubernetes-ingress/blob/docs/release-3.4.0/examples/custom-resources/service-insight/README.md?plain=1#L35 https://github.com/nginxinc/kubernetes-ingress/blob/docs/release-3.4.0/examples/custom-resources/service-insight/README.md?plain=1#L324

Nice catch @haywoodsh
I feel we can probably remove a lot of the example deployment file for service-insights so that we don't need to keep that image version updated. It's only really there to show an example.

shaun-nx
shaun-nx reviewed Dec 14, 2023
View reviewed changes
docs/content/releases.md Outdated Show resolved Hide resolved
@haywoodsh haywoodsh mentioned this pull request Dec 15, 2023
Closed
@pdabelf5 pdabelf5 enabled auto-merge (squash) December 19, 2023 11:05
@pdabelf5 pdabelf5 merged commit 0811b5c into release-3.4 Dec 19, 2023
11 checks passed
@pdabelf5 pdabelf5 deleted the docs/release-3.4.0 branch December 19, 2023 11:10
pdabelf5 added a commit that referenced this pull request Dec 19, 2023
@nginx-bot @pdabelf5 @shaun-nx
Release 3.4.0 (#4794)
4e37bb1 
* Release 3.4.0

---------

Co-authored-by: Paul Abel <[email protected]>
Co-authored-by: shaun-nx <[email protected]>
Co-authored-by: Paul Abel <[email protected]>
pdabelf5 added a commit that referenced this pull request Dec 19, 2023
@pdabelf5
Cherry pick 3.4.0 docs (#4822)
484b6e0 
* Release 3.4.0 (#4794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx shaun-nx left review comments

@jasonwilliams14 jasonwilliams14 jasonwilliams14 left review comments

@haywoodsh haywoodsh haywoodsh left review comments

@brianehlert brianehlert brianehlert left review comments

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nginx-bot @shaun-nx @brianehlert @haywoodsh @j1m-ryan @jasonwilliams14 @vepatel @pdabelf5