Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick 3.4.0 docs #4822

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Cherry pick 3.4.0 docs #4822

merged 3 commits into from
Dec 19, 2023

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 19, 2023 •
edited
Loading

Proposed changes

Cherry Pick docs updates from release-3.4 branch

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

nginx-bot and others added 2 commits December 19, 2023 14:44
@nginx-bot @pdabelf5 @shaun-nx
Release 3.4.0 (#4794)
4e37bb1 
* Release 3.4.0

---------

Co-authored-by: Paul Abel <[email protected]>
Co-authored-by: shaun-nx <[email protected]>
Co-authored-by: Paul Abel <[email protected]>
@pdabelf5
minor docs updates (#4821)
8b757d9
@pdabelf5 pdabelf5 requested review from a team as code owners December 19, 2023 14:47
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Dec 19, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a02083) 52.01% compared to head (13ba573) 52.03%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4822      +/-   ##
==========================================
+ Coverage   52.01%   52.03%   +0.02%     
==========================================
  Files          60       60              
  Lines       17313    17313              
==========================================
+ Hits         9005     9009       +4     
+ Misses       7995     7993       -2     
+ Partials      313      311       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jjngx
jjngx approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@pdabelf5 pdabelf5 merged commit 484b6e0 into main Dec 19, 2023
72 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-3.4.0-docs branch December 19, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pdabelf5 @j1m-ryan @vepatel @jjngx @nginx-bot