Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script does not update helm chart version #4809

Closed
haywoodsh opened this issue Dec 15, 2023 · 1 comment · Fixed by #4810
Closed

Release script does not update helm chart version #4809

haywoodsh opened this issue Dec 15, 2023 · 1 comment · Fixed by #4810

Comments

@haywoodsh
Copy link
Contributor

Describe the bug
The release version update script does not update helm chart version to the one specified in the argument in ${ROOTDIR}/deployments or in docs
Since we change from IC version to helm chart version in the helm installation docs, it is not included in the script.

To Reproduce
Steps to reproduce the behavior:

  1. run the script locally
    sh .github/scripts/release-version-update.sh 3.4.0 1.1.0
    
  2. Search for instances of old current version in the repo, e.g. 1.0.2

Expected behavior
All helm versions should be updated when this script is run.
Your environment

Observed in #4794 by nginx-bot and locally with main branch.

Additional context
Add any other context about the problem here. Any log files you want to share.

Copy link

Hi @haywoodsh thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@haywoodsh haywoodsh closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant