Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the DNSEndpoint resource when VS is deleted & Ratelimit requeues on errors. #4504

Merged
merged 2 commits into from
Nov 17, 2023

Add rate limiting to extdns retries, return nil when VS deleted

5a8ddf2
Select commit
Loading
Failed to load commit list.
Merged

Delete the DNSEndpoint resource when VS is deleted & Ratelimit requeues on errors. #4504

Add rate limiting to extdns retries, return nil when VS deleted
5a8ddf2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 15, 2023 in 1s

51.94% (-0.05%) compared to c7680a4

View this Pull Request on Codecov

51.94% (-0.05%) compared to c7680a4

Details

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (c7680a4) 51.99% compared to head (5a8ddf2) 51.94%.

Files Patch % Lines
internal/externaldns/controller.go 0.00% 6 Missing ⚠️
internal/certmanager/cm_controller.go 0.00% 4 Missing ⚠️
internal/externaldns/sync.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4504      +/-   ##
==========================================
- Coverage   51.99%   51.94%   -0.05%     
==========================================
  Files          59       59              
  Lines       16960    16972      +12     
==========================================
- Hits         8818     8816       -2     
- Misses       7847     7859      +12     
- Partials      295      297       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.