New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the DNSEndpoint resource when VS is deleted & Ratelimit requeues on errors. #4504

Merged

shaun-nx merged 2 commits into main from feat/delete-extdns-vs-deleted

Nov 17, 2023

Merged

Delete the DNSEndpoint resource when VS is deleted & Ratelimit requeues on errors. #4504

Add rate limiting to extdns retries, return nil when VS deleted

Codecov / codecov/patch succeeded Nov 15, 2023 in 0s

0.00% of diff hit (target 51.99%)

View this Pull Request on Codecov

0.00% of diff hit (target 51.99%)

Annotations

Check warning on line 153 in internal/certmanager/cm_controller.go

codecov / codecov/patch

internal/certmanager/cm_controller.go#L150-L153

Added lines #L150 - L153 were not covered by tests

Check warning on line 169 in internal/externaldns/controller.go

codecov / codecov/patch

internal/externaldns/controller.go#L169

Added line #L169 was not covered by tests

Check warning on line 173 in internal/externaldns/controller.go

codecov / codecov/patch

internal/externaldns/controller.go#L173

Added line #L173 was not covered by tests

Check warning on line 191 in internal/externaldns/controller.go

codecov / codecov/patch

internal/externaldns/controller.go#L188-L191

Added lines #L188 - L191 were not covered by tests

Check warning on line 160 in internal/externaldns/sync.go

codecov / codecov/patch

internal/externaldns/sync.go#L158-L160

Added lines #L158 - L160 were not covered by tests

Check warning on line 167 in internal/externaldns/sync.go

codecov / codecov/patch

internal/externaldns/sync.go#L167

Added line #L167 was not covered by tests

View more details on Codecov