Delete the DNSEndpoint resource when VS is deleted & Ratelimit requeues on errors. #4504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When a VirtualServer with ExternalDNS enabled is deleted, the corresponding DNSEndpoint resource is not cleaned up. Additionally, we are endlessly re-queuing VS objects with ExternalDNS enabled with errors without rate limiting.
Also, we are not checking if the VS has been deleted before re-queuing, in both the external dns controller, and the cert-manager controller.
This commit rectifies these issues by:
Checklist
Closes #4418
Before creating a PR, run through this checklist and mark each as complete.