Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: enable to use CRDs imported as modules #4152

Merged
merged 8 commits into from
Sep 4, 2023

Conversation

9bany
Copy link
Contributor

@9bany 9bany commented Jul 26, 2023

Reopen from this pull #3897

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@9bany 9bany requested a review from a team as a code owner July 26, 2023 10:02
@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart labels Jul 26, 2023
@9bany 9bany force-pushed the feat/unable-use-CRDs-import-as-modules branch from bfa1cf2 to 7fbb010 Compare July 26, 2023 10:07
@jjngx jjngx self-assigned this Jul 26, 2023
@jjngx jjngx added this to the v3.3.0 milestone Jul 26, 2023
@lucacome lucacome linked an issue Jul 26, 2023 that may be closed by this pull request
@jjngx
Copy link
Contributor

jjngx commented Aug 2, 2023

@9bany can I ask you to update your remote and push changes please?

@jjngx
Copy link
Contributor

jjngx commented Aug 3, 2023

@9bany could you please update your branch, run make update-codegen and then push?

@jjngx jjngx added the waiting for response Waiting for author's response label Aug 8, 2023
@vepatel
Copy link
Contributor

vepatel commented Aug 24, 2023

ping @9bany

@9bany
Copy link
Contributor Author

9bany commented Aug 25, 2023

let me pick it up !

@github-actions github-actions bot removed the helm_chart Pull requests that update the Helm Chart label Aug 26, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4152 (2cfe781) into main (1342aa6) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 2cfe781 differs from pull request most recent head a28be49. Consider uploading reports for the commit a28be49 to get more accurate results

@@            Coverage Diff             @@
##             main    #4152      +/-   ##
==========================================
+ Coverage   52.19%   52.20%   +0.01%     
==========================================
  Files          59       59              
  Lines       16930    16930              
==========================================
+ Hits         8837     8839       +2     
+ Misses       7796     7794       -2     
  Partials      297      297              
Files Changed Coverage Δ
cmd/nginx-ingress/main.go 0.00% <ø> (ø)
internal/certmanager/cm_controller.go 12.12% <ø> (ø)
internal/certmanager/helper.go 87.50% <ø> (ø)
internal/certmanager/sync.go 72.95% <ø> (ø)
internal/configs/config_params.go 77.77% <ø> (ø)
internal/configs/configmaps.go 22.27% <ø> (ø)
internal/configs/configurator.go 37.94% <ø> (ø)
internal/configs/ingress.go 76.90% <ø> (ø)
internal/configs/transportserver.go 97.90% <ø> (ø)
internal/configs/virtualserver.go 94.57% <ø> (ø)
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM, thanks for contributing @9bany . Could you please update your branch and push?

@jjngx jjngx requested review from ciarams87, shaun-nx, haywoodsh, a team and vepatel August 28, 2023 12:57
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jjngx jjngx requested a review from a team August 29, 2023 08:53
CHANGELOG.md Outdated Show resolved Hide resolved
@vepatel vepatel added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation labels Aug 29, 2023
@9bany 9bany changed the title feature: unable to use CRDs imported as modules feature: enable to use CRDs imported as modules Aug 29, 2023
@vepatel vepatel merged commit f14e910 into nginx:main Sep 4, 2023
@vepatel vepatel mentioned this pull request Sep 5, 2023
@9bany 9bany deleted the feat/unable-use-CRDs-import-as-modules branch September 6, 2023 03:11
@lucacome lucacome removed this from the v3.3.0 milestone Sep 25, 2023
@lucacome lucacome added the skip changelog Pull requests that don't need to be added to the changelog label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Pull requests for new features/feature enhancements skip changelog Pull requests that don't need to be added to the changelog waiting for response Waiting for author's response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use CRDs imported as modules
6 participants