Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use CRDs imported as modules #3770

Open
nixx opened this issue Apr 14, 2023 · 7 comments · Fixed by #4152
Open

Unable to use CRDs imported as modules #3770

nixx opened this issue Apr 14, 2023 · 7 comments · Fixed by #4152
Assignees
Labels
backlog Pull requests/issues that are backlog items
Milestone

Comments

@nixx
Copy link

nixx commented Apr 14, 2023

Describe the bug
When automating the configuration for NGINX Ingress Controller, we need access to the CRDs. Importing them as a golang module, is preferrable.

To Reproduce
Steps to reproduce the behavior:
Running " go get -u github.com/nginxinc/kubernetes-ingress" will fail with " require github.com/nginxinc/kubernetes-ingress: version "v3.1.0" invalid: should be v0 or v1, not v3"

This is fixable with adding /v3 in the module name in go.mod.

Expected behavior
Expecting to be able to import the module.
I do get around it with psedo-versions (go get -u github.com/nginxinc/[email protected])

Your environment
v3.1.0
Kubernetes: N/A

@github-actions
Copy link

Hi @nixx thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@haywoodsh haywoodsh added the proposal An issue that proposes a feature request label Apr 19, 2023
@lucacome
Copy link
Member

Hi @nixx the Ingress Controller is not really designed to be imported as a module. Can you share more info about your workflow and how you use it as a module? I think it's the first time we hear about this use case 🙂

@danielnginx danielnginx added good first issue Issues identified as good for first-time contributors backlog candidate Pull requests/issues that are candidates to be backlog items backlog Pull requests/issues that are backlog items and removed backlog candidate Pull requests/issues that are candidates to be backlog items labels May 4, 2023
@jjngx
Copy link
Contributor

jjngx commented May 17, 2023

Hi @nixx,
Thanks for reporting the issue. We are planning to make the module importable, so packages could be used by referencing v3.

@brianehlert brianehlert linked a pull request May 17, 2023 that will close this issue
6 tasks
@jjngx jjngx self-assigned this Jul 11, 2023
@brianehlert brianehlert added this to the v3.3.0 milestone Jul 11, 2023
@lucacome lucacome linked a pull request Jul 26, 2023 that will close this issue
6 tasks
@brianehlert brianehlert removed the proposal An issue that proposes a feature request label Jul 26, 2023
@vepatel vepatel reopened this Sep 6, 2023
@vepatel
Copy link
Contributor

vepatel commented Sep 6, 2023

reopening as merging #4152 is causing local build issue as described in #4324
cc @9bany @jjngx @danielnginx

@brianehlert brianehlert modified the milestones: v3.3.0, v3.4.0 Sep 20, 2023
@brianehlert brianehlert modified the milestones: v3.4.0, v3.5.0 Dec 7, 2023
@jjngx
Copy link
Contributor

jjngx commented Dec 21, 2023

@nixx which packages do you want to import to your module?

for the ref

@jjngx
Copy link
Contributor

jjngx commented Jan 3, 2024

Work on this item can be resumed when we get more information from @nixx, and possible target V4 (version 4.0.0) of the Kubernetes-ingress module.

@shaun-nx shaun-nx removed the good first issue Issues identified as good for first-time contributors label Jan 3, 2024
@brianehlert brianehlert removed this from the v3.5.0 milestone Jan 3, 2024
@shaun-nx shaun-nx self-assigned this Jan 3, 2024
@shaun-nx shaun-nx added this to the Candidates milestone Sep 4, 2024
@lucacome lucacome moved this to Todo ☑ in NGINX Ingress Controller Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items
Projects
Status: Todo ☑
8 participants