Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "enable use of CRDs imported as modules (#4152)" #4327

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Revert "enable use of CRDs imported as modules (#4152)" #4327

merged 2 commits into from
Sep 6, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Sep 6, 2023 •
edited
Loading

Proposed changes

Revert "enable use of CRDs imported as modules (#4152)"
Commit: f14e910.
Issue: #4324
Testing: verified by building OSS and Plus Images locally

docker build --platform linux/amd64 --platform linux/amd64 --build-arg IC_VERSION=revert --target container -f build/Dockerfile -t nginx-ingress:revert . --build-arg BUILD_OS=debian
[+] Building 37.9s (29/29) FINISHED

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner September 6, 2023 10:07
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Sep 6, 2023
@vepatel vepatel linked an issue Sep 6, 2023 that may be closed by this pull request
main builds are broken #4324
Closed
@vepatel vepatel merged commit b44efbb into main Sep 6, 2023
@vepatel vepatel deleted the bugfix/revert-PR-4152 branch September 6, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx shaun-nx approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

main builds are broken
3 participants
@vepatel @haywoodsh @shaun-nx