feat(theming): Align theming closer to files app

[stefan-niedermann]

Follow-Up to #1680

• Background color is now @color/bg_default, like in the Files app
• Statusbars and Toolbars are now themed, except on the main view
• I tackled some technical debts (odd horizontal paddings in toolbars, see Start/end padding in lighter black that rest of appbar #889)

Open issues:

• SettingsActivity: Back arrow is not perfectly aligned with icons. I propose to just keep it as it is for now.
• The toolbar icons do have a different position in the main activity compared to each other activity - because of placing it inside of the rounded card. This behavior will be the same when we switch to the material SearchBar
• ActionMode could need some more love

Out of scope:

• Switching to an actual material SearchBar for the main view

_	_

Would love to get some feedback @AndyScherzinger

[AndyScherzinger]

looks good to me @stefan-niedermann 👍

[AndyScherzinger]

Minor detail, the 3-dot overflow menu icons should be tinted the same way the other trailing icons are tinted.

see:

https://github.com/nextcloud/android-common/blob/08db28c1a4ca825c82ddf56747d7892c719550a7/ui/src/main/java/com/nextcloud/android/common/ui/theme/utils/MaterialViewThemeUtils.kt#L58-L62

[AndyScherzinger]

Minor detail, the 3-dot overflow menu icons should be tinted the same way the other trailing icons are tinted.

Well, it is also like that in the talk app, so maybe keep it as is for the moment 👍

[stefan-niedermann]

the 3-dot overflow menu icons should be tinted the same way the other trailing icons are tinted.

Maybe themeToolbar should call colorToolbarOverflowIcon implicitly? It would fix also the Talk app then and would at least match my persobal expectations...

[AndyScherzinger]

I now fixed in for talk explicitly but yeah, makes sense to call it within the toolbar theming logic 👍

[AndyScherzinger]

android-common 0.8.0 ships a fix for theming the trailing icons (overflow icon) when theming the toolbar. 👍

[stefan-niedermann]

👍 Ready to merge from my side