Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start/end padding in lighter black that rest of appbar #889

Closed
thgoebel opened this issue Jun 20, 2020 · 4 comments
Closed

Start/end padding in lighter black that rest of appbar #889

thgoebel opened this issue Jun 20, 2020 · 4 comments
Labels
bug UX user experience

Comments

@thgoebel
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug

In dark mode, the padding at the start/end of the action bar has a slightly lighter color.

To Reproduce

  1. Open the view/edit screen.

Expected behavior

Action bar should be the same color throughout.

Screenshots

Smartphone (please complete the following information):

  • Nextcloud Notes-Version (android app): 2.16.2
  • F-Droid or Play Store: github
  • Android-Version: 10
  • Device: OnePlus 7

Server

  • Nextcloud version:
  • Nextcloud Notes version (server app):

Stacktrace

@stefan-niedermann
Copy link
Member

Hmm, any idea what's causing it? It's also in AboutActivity, PreferencesActivity and so on...

Even if i set android:background="@color/primary" on the AppBar directly, it has no effect...

@stefan-niedermann stefan-niedermann added bug UX user experience labels Jun 20, 2020
@thgoebel
Copy link
Contributor Author

If I had known immediately, I'd have send a PR :)

@stefan-niedermann
Copy link
Member

Also affects the toolbar of the NotesListViewActivity as soon as one clicks on the MaterialCard.

@stefan-niedermann
Copy link
Member

So, i found out that it works if i explicitly set the background color of the AppBarLayout programmatically.
This is good enough as a workaround for me, i left a FIXME in the code so one can have a closer look whenever one has time for racking brains why the hell android does not accept the declarative background color.... 😕

Thanks for reporting 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UX user experience
Projects
None yet
Development

No branches or pull requests

2 participants