feat(theming): Use nextcloud-common library for theming UI elements (#1648) #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Niedermann <[email protected]>
stefan-niedermann
requested review from
AndyScherzinger,
tobiasKaminsky and
AlvaroBrey
Signed-off-by: Stefan Niedermann <[email protected]>
Signed-off-by: Stefan Niedermann <[email protected]>
... and rely on PlatformThemeUtil.isDarkMode in stead. Signed-off-by: Stefan Niedermann <[email protected]>
|
So I will stop here and give you some time to for a review - sorry, it already grew larger than I originally planned... |
|
The screenshots look good to me 👍 |
|
Fine by me. |
AlvaroBrey
requested changes
Feb 16, 2023
app/src/main/java/it/niedermann/owncloud/notes/branding/NotesViewThemeUtils.java
Outdated
Show resolved
Hide resolved
app/src/main/java/it/niedermann/owncloud/notes/main/MainActivity.java
Outdated
Show resolved
Hide resolved
* Only add the needed module rather than the entire lib * Use ColorRole where possible in favor of querying the wanted color from the Scheme directly * Use util for theming SwipeRefreshLayout Signed-off-by: Stefan Niedermann <[email protected]>
…vor of AndroidViewThemeUtils#highlightText Signed-off-by: Stefan Niedermann <[email protected]>
AlvaroBrey
approved these changes
Feb 16, 2023
|
A bit too late, but I just noticed, that this will unresolve #769 - see also nextcloud/android-common#79 It is not a big deal yet, because the excerpts are quite small. I want to use the theming in the |
stefan-niedermann
added a commit
that referenced
this pull request
Apr 7, 2023
Follow-Up to #1680 Signed-off-by: Stefan Niedermann <[email protected]>
stefan-niedermann
added a commit
that referenced
this pull request
Apr 7, 2023
Follow-Up to #1680 Signed-off-by: Stefan Niedermann <[email protected]>
stefan-niedermann
added a commit
that referenced
this pull request
Apr 7, 2023
Fix navigation view background Follow-Up to #1680 Signed-off-by: Stefan Niedermann <[email protected]>
stefan-niedermann
added a commit
that referenced
this pull request
Apr 11, 2023
Follow-Up to #1680 Signed-off-by: Stefan Niedermann <[email protected]>
AndyScherzinger
pushed a commit
that referenced
this pull request
Apr 11, 2023
Follow-Up to #1680 Signed-off-by: Stefan Niedermann <[email protected]>
AndyScherzinger
pushed a commit
that referenced
this pull request
Apr 11, 2023
Follow-Up to #1680 Signed-off-by: Stefan Niedermann <[email protected]>
AndyScherzinger
pushed a commit
that referenced
this pull request
Apr 11, 2023
Fix navigation view background Follow-Up to #1680 Signed-off-by: Stefan Niedermann <[email protected]>
AndyScherzinger
pushed a commit
that referenced
this pull request
Apr 11, 2023
Follow-Up to #1680 Signed-off-by: Stefan Niedermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an intermediate step to an alignment with the Material Files and Talk app.
Most important class:
BrandingUtil- is more or less what you know asViewThemeUtilsin the Files app.Something more you should know: I created also a class
NotesViewThemeUtilsas a place to put app specific styling stuff until they are available within theandroid-commonlibrary. It will probably fail because of the "No more Java" GitHub action you put in place 😉 So either we need to convert it to Kotlin or you make an exception for intermediate steps 🤷♂️ .FloatingActionButtons,EditTexts,SwitchPreferences and so on) and is already done viaandroid-commonIf you have own plans or think this goes into the wrong direction, please let me know.
👁️ Screenshots
Only made with base color
#0082C9for time reasons, but the other colors look as expected and aligned with the Files app, too.