-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neon_framework): Implement deleting accounts on the server #1670
Conversation
I think another action in the appbar is confusing for users. A dialog with two options. |
Nice !
|
The details field is already used, but the delay isn't yet. I'll rewrite the UI to use the dialog and then those can also be displayed in a nice way. |
@provokateurin maybe don't make the dialogue adaptive. The RadioListTile will require a material ancestor and even if we wrap it in a material widget it'll look out of place on iOS anyways. |
The CI failure is due to nextcloud/server#43877 and I hope I can get it into 28.0.3, otherwise we can just manually patch it for the time being (or update to a mid-release 28 snapshot). |
fd73366
to
2f546b6
Compare
In case the server doesn't have the drop_account app the old dialog will be shown. I think it is pretty ugly to provide a radio that only has one option. |
So I'll need to manually install the app into the docker container to test it? |
Just rebuild the docker images and delete your volumes.
https://apps.nextcloud.com/apps/drop_account it is, but you can't search for app IDs in the store... |
Ok code and UI looks good. |
2f546b6
to
5025c0e
Compare
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
5025c0e
to
f3d9966
Compare
Slow CI + a lot of random failure 🥲 |
Closes #732
We can not directly use the endpoint because of #1492, so I opted for implementing it like the mobile clients which just open the settings page in the browser. For that reason I also patched the spec to remove the endpoint as it is not possible to use it (yet).