Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend account deletion dialogue #12015

Merged
merged 18 commits into from
Nov 30, 2023
Merged

Extend account deletion dialogue #12015

merged 18 commits into from
Nov 30, 2023

Conversation

ZetaTom
Copy link
Collaborator

@ZetaTom ZetaTom commented Oct 10, 2023

This change extends the Remove account dialogue to include an option to request ones account to be permanently deleted.
In order for the Request account deletion option to appear, an up-to-date version of the User account deletion app must be installed on the corresponding server.

Previous Versions Without drop_account With drop_account
previous without with

blocked by nextcloud/android-library#1213
closes #11950

  • Tests written, or not not needed

@ZetaTom ZetaTom force-pushed the wip/account-deletion-dialogue branch from aa1a583 to 2f353f5 Compare October 12, 2023 07:01
@tobiasKaminsky
Copy link
Member

If primary color is not NC color, then both buttons shall be tinted.

2023-10-13-100708

@tobiasKaminsky tobiasKaminsky force-pushed the wip/account-deletion-dialogue branch from eb2c849 to e2ca281 Compare October 13, 2023 08:14
@tobiasKaminsky
Copy link
Member

Storing new value is missing.
We can discuss this on Monday.

jancborchardt
jancborchardt approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, nice work @ZetaTom! :)

@ZetaTom ZetaTom force-pushed the wip/account-deletion-dialogue branch 2 times, most recently from 6414838 to 3c04971 Compare November 7, 2023 08:05
@tobiasKaminsky
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the wip/account-deletion-dialogue branch from 258f1bc to 39da4f9 Compare November 22, 2023 08:04
ZetaTom and others added 12 commits November 27, 2023 13:25
@ZetaTom
Extended AccountRemovalDialog
90ec0dd 
- port account deletion dialogue to Kotlin
- rename dialogue to `AccountRemovalDialog`
- introduce custom view for dialogue content

Signed-off-by: ZetaTom <[email protected]>
@ZetaTom
Extended AccountRemovalDialog
57d2bd6 
- add option to request deletion
- add android-library to settings.gradle

Signed-off-by: ZetaTom <[email protected]>
@ZetaTom
Extended AccountRemovalDialog
3156493 
- added required functionality and improved appearance
- added comments

Signed-off-by: ZetaTom <[email protected]>
@ZetaTom
Extended AccountRemovalDialog
be73b12 
- list item is now clickable as a whole
- commented out includeBuild in settings.gradle

Signed-off-by: ZetaTom <[email protected]>
@ZetaTom
Extended AccountRemovalDialog
aac41da 
- port account deletion dialogue to Kotlin
- rename dialogue to `AccountRemovalDialog`
- introduce custom view for dialogue content

Signed-off-by: ZetaTom <[email protected]>
@ZetaTom
Extended AccountRemovalDialog
bab3443 
- add option to request deletion
- add android-library to settings.gradle

Signed-off-by: ZetaTom <[email protected]>
@ZetaTom
Extended AccountRemovalDialog
dc73d6f 
- added required functionality and improved appearance
- added comments

Signed-off-by: ZetaTom <[email protected]>
@ZetaTom
Extended AccountRemovalDialog
de4dba2 
- list item is now clickable as a whole
- commented out includeBuild in settings.gradle

Signed-off-by: ZetaTom <[email protected]>
@tobiasKaminsky @ZetaTom
temporarily move to feature branch
3a6854b 
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky @ZetaTom
migrate to 74 and reset capabilities
200e2db 
Signed-off-by: tobiasKaminsky <[email protected]>
@ZetaTom
Persist drop-account capability.
4ff1b3d 
Signed-off-by: ZetaTom <[email protected]>
@ZetaTom
Remove legacy AccountRemovalConfirmationDialog.kt
c9f27b7 
Signed-off-by: ZetaTom <[email protected]>
@ZetaTom ZetaTom force-pushed the wip/account-deletion-dialogue branch from 39da4f9 to 144e1dc Compare November 27, 2023 12:39
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7070
Dodgy code360360
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total554554

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12015.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Nov 29, 2023
@tobiasKaminsky tobiasKaminsky merged commit ab92579 into master Nov 30, 2023
19 of 21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the wip/account-deletion-dialogue branch November 30, 2023 08:41
@Leptopoda Leptopoda mentioned this pull request Feb 27, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

Assignees
No one assigned
Labels
4. to release design feedback-requested ❄️ 2023-Winter
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.

Account deletion mandatory from within Android apps
5 participants
@ZetaTom @tobiasKaminsky @jancborchardt @alperozturk96 @AndyScherzinger