Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provisioning_api): Fix AppInfo schema for OpenAPI #43877

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Feb 27, 2024

Summary

There are a few mistakes in the current schema (e.g. multiple language support for name, description and summary). Instead of trying to fix those problems I opted for generalizing the whole schema as the provided type information was mostly useless anyway (values typed as ?mixed). This could have also led to problems in case the XSD was updated and this schema wasn't, so this avoids it. The real problem is that the AppStore data is simply passed through without any checking for any structure, but that can't be fixed easily.

Checklist

@provokateurin
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

This was referenced Mar 12, 2024
@provokateurin provokateurin merged commit 05d020d into master Mar 14, 2024
160 checks passed
@provokateurin provokateurin deleted the fix/provisioning_api/app-info-schema branch March 14, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants